Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2272093003: Use SdkExtensionFinder in the old Analysis Server implementation. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use SdkExtensionFinder in the old Analysis Server implementation. To be replaced with ContextBuilder of course. But we need this for the time being. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/af6bd2ef88e7c1d769d403f4a0e56621f7647851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 7 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-08-24 20:34:31 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-24 20:50:10 UTC) #2
scheglov
4 years, 4 months ago (2016-08-24 20:58:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af6bd2ef88e7c1d769d403f4a0e56621f7647851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698