Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2272053002:
Print Preview: Fix fit to page checkbox. (Closed)
DescriptionPrint Preview: Fix fit to page checkbox.
BUG=568415
Committed: https://crrev.com/e48f535b7adc64eea059a4296577b193dd8c0c86
Cr-Commit-Position: refs/heads/master@{#414794}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix comment #
Total comments: 2
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Fix fit to page checkbox. BUG=568415 ========== to ========== Fix fit to page checkbox. BUG=568415 ==========
rbpotter@chromium.org changed reviewers: + thestig@chromium.org
Quick fix for the fit to page bug. Note: added an extra parameter to the "PDF should disable scaling" function so that the new behavior only affects the call when we are doing the "first time" check. I'm assuming we wouldn't want the behavior to change in other cases.
Description was changed from ========== Fix fit to page checkbox. BUG=568415 ========== to ========== Print Preview: Fix fit to page checkbox. BUG=568415 ==========
lgtm https://codereview.chromium.org/2272053002/diff/1/components/printing/rendere... File components/printing/renderer/print_web_view_helper.cc (right): https://codereview.chromium.org/2272053002/diff/1/components/printing/rendere... components/printing/renderer/print_web_view_helper.cc:332: // - |ignore_page_size| is true and the uniform size is the same as the paper is true -> is false?
The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rbpotter@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org Link to the patchset: https://codereview.chromium.org/2272053002/#ps20001 (title: "Fix comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Print Preview: Fix fit to page checkbox. BUG=568415 ========== to ========== Print Preview: Fix fit to page checkbox. BUG=568415 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Print Preview: Fix fit to page checkbox. BUG=568415 ========== to ========== Print Preview: Fix fit to page checkbox. BUG=568415 Committed: https://crrev.com/e48f535b7adc64eea059a4296577b193dd8c0c86 Cr-Commit-Position: refs/heads/master@{#414794} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e48f535b7adc64eea059a4296577b193dd8c0c86 Cr-Commit-Position: refs/heads/master@{#414794}
Message was sent while issue was closed.
larrylaca818@yahoo.com changed reviewers: + LarryLACA818@yahoo.com, rbpotter@chromium.org
Message was sent while issue was closed.
FYI, editorial comments only. Fix works OK for me (Win10) as is. https://codereview.chromium.org/2272053002/diff/20001/components/printing/ren... File components/printing/renderer/print_web_view_helper.cc (right): https://codereview.chromium.org/2272053002/diff/20001/components/printing/ren... components/printing/renderer/print_web_view_helper.cc:333: // size. Editorial cmt only, no impact: description should read // Disable scaling when either: // - The PDF specifies disabling scaling, // - |ignore_page_size| is false // - All the pages in the PDF are the same size, // - The uniform size is the same as the paper size. Keeps the same size logic together, there is no && condition between ignore_page_size and uniform size https://codereview.chromium.org/2272053002/diff/20001/components/printing/ren... components/printing/renderer/print_web_view_helper.cc:351: if (ignore_page_size) Editorial cmt only, no impact The if (ignore_page_size) check should precede the !dpi check. The !dpi check protects the page_size() call just below. |
