Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2272023002: Turn AppList context menus Async (Closed)

Created:
4 years, 4 months ago by jonross
Modified:
4 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn AppList context menus Async Update each of the context menus in AppList to use the ASYNC runtype for menus. None of the menus had followups to menu closure. I left the current lifetime of the MenuRunners as is. TEST=manually tested each context menu, app_list_unittests BUG=557136 Committed: https://crrev.com/4bc916c16e503d30df856c4d8d54c4c735555a40 Cr-Commit-Position: refs/heads/master@{#414473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M ui/app_list/views/app_list_item_view.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M ui/app_list/views/app_list_menu_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_result_tile_item_view.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M ui/app_list/views/search_result_view.cc View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jonross
Hi xiyuan@, I'm working on transitioning menus from the current nested message loop, to a ...
4 years, 3 months ago (2016-08-25 13:29:34 UTC) #6
xiyuan
lgtm Great to see the nested loop gone!
4 years, 3 months ago (2016-08-25 16:05:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272023002/1
4 years, 3 months ago (2016-08-25 16:55:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 18:09:52 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:12:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bc916c16e503d30df856c4d8d54c4c735555a40
Cr-Commit-Position: refs/heads/master@{#414473}

Powered by Google App Engine
This is Rietveld 408576698