Clean up CPDF_TextPage

Remove unused methods in CPDF_TextPage and nits

fpdf_text_int.cpp should be split up into classes in a later CL

Committed: https://pdfium.googlesource.com/pdfium/+/43cbe9ea0ff1d0d8b0a7a5c84e5a96f83aec78c1

[npm, 2016-08-24 21:33:50]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 21:33:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-08-24 21:37:20]

Description was changed from

==========
Clean up CPDF_TextPage
==========

to

==========
Remove unused methods in CPDF_TextPage and nits

fpdf_text_int.cpp should be split up into classes in a later CL
==========

[npm, 2016-08-24 21:37:20]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:44:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:44:28]

Dry run: This issue passed the CQ dry run.

[npm, 2016-08-24 21:45:24]

PTAL

[Lei Zhang, 2016-08-25 01:14:25]

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:264: bool flagNewRect = true;
bFlagNewRect

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:315: if (rect.left >
info_curchar.m_CharBox.left)
std::min/max?

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:386: if (strText.GetLength() > 0)
GetLength() > 0 -> !IsEmpty()

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1010: if (item.m_CharCode == (uint32_t)-1)
static_cast

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1298: if (strCurText.GetLength() == 0)
GetLength() == 0 -> IsEmpty()

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1349: wstrItem += (FX_WCHAR)item.m_CharCode;
Remove C-cast.

[npm, 2016-08-25 14:13:26]

PTAL

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
File core/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:264: bool flagNewRect = true;
On 2016/08/25 01:14:25, Lei Zhang wrote:
> bFlagNewRect

Done.

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:315: if (rect.left >
info_curchar.m_CharBox.left)
On 2016/08/25 01:14:25, Lei Zhang wrote:
> std::min/max?

Done.

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:386: if (strText.GetLength() > 0)
On 2016/08/25 01:14:25, Lei Zhang wrote:
> GetLength() > 0 -> !IsEmpty()

Done.

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1010: if (item.m_CharCode == (uint32_t)-1)
On 2016/08/25 01:14:25, Lei Zhang wrote:
> static_cast

Done.

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1298: if (strCurText.GetLength() == 0)
On 2016/08/25 01:14:25, Lei Zhang wrote:
> GetLength() == 0 -> IsEmpty()

Done.

https://codereview.chromium.org/2271973004/diff/1/core/fpdftext/fpdf_text_int...
core/fpdftext/fpdf_text_int.cpp:1349: wstrItem += (FX_WCHAR)item.m_CharCode;
On 2016/08/25 01:14:25, Lei Zhang wrote:
> Remove C-cast.

Done.

[Lei Zhang, 2016-08-25 15:03:41]

lgtm

[npm, 2016-08-25 15:04:22]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-08-25 15:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 15:13:25]

Description was changed from

==========
Remove unused methods in CPDF_TextPage and nits

fpdf_text_int.cpp should be split up into classes in a later CL
==========

to

==========
Remove unused methods in CPDF_TextPage and nits

fpdf_text_int.cpp should be split up into classes in a later CL

Committed:
https://pdfium.googlesource.com/pdfium/+/43cbe9ea0ff1d0d8b0a7a5c84e5a96f83aec...
==========

[commit-bot: I haz the power, 2016-08-25 15:13:26]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/43cbe9ea0ff1d0d8b0a7a5c84e5a96f83aec...