Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2271973003: [turbofan] Use ObjectIsReceiver directly for inlining. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use ObjectIsReceiver directly for inlining. Don't bother using %_IsJSReceiver, which immediately gets lowered to ObjectIsReceiver anyways (by the JSIntrinsicLowering), but requires some complicated rewiring of effect/control chains. R=mstarzinger@chromium.org BUG=chromium:640369 Committed: https://crrev.com/6646d73b6f387e7ef6add056cc022b6dafe03d36 Cr-Commit-Position: refs/heads/master@{#38864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M src/compiler/js-inlining.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 3 chunks +8 lines, -8 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-640369.js View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-24 10:48:41 UTC) #1
Michael Starzinger
LGTM. Simplified carpet is best carpet.
4 years, 4 months ago (2016-08-24 10:50:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271973003/1
4 years, 4 months ago (2016-08-24 11:01:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 11:09:27 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 11:09:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6646d73b6f387e7ef6add056cc022b6dafe03d36
Cr-Commit-Position: refs/heads/master@{#38864}

Powered by Google App Engine
This is Rietveld 408576698