Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2271953002: Remove Platform::current checks from Mojo's error handlers in geolocation (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 3 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, haraken, timvolodine, mvanouwerkerk+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Platform::current checks from Mojo's error handlers in geolocation The checks were added in https://codereview.chromium.org/2163683004/ but are no longer needed because I already removed blink::shutdown from the renderer's shutdown sequence. BUG=628999, 639244 Committed: https://crrev.com/8435863a81be1eee4c28131a341f8a4bce04a7b4 Cr-Commit-Position: refs/heads/master@{#414232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
haraken
PTAL
4 years, 4 months ago (2016-08-24 07:15:22 UTC) #2
Sam McNally
lgtm
4 years, 4 months ago (2016-08-24 21:42:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271953002/1
4 years, 4 months ago (2016-08-24 22:50:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 00:52:00 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8435863a81be1eee4c28131a341f8a4bce04a7b4 Cr-Commit-Position: refs/heads/master@{#414232}
4 years, 4 months ago (2016-08-25 00:56:20 UTC) #8
haraken
4 years, 3 months ago (2016-09-05 00:28:29 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2312553003/ by haraken@chromium.org.

The reason for reverting is: I'll revert r413430 and its dependent CLs because
r413430 caused issue 642072.

The problem is that we cannot simply remove blink::shutdown because the
following scenario can happen:

1) blink::shutdown is not called. Workers are still running.
2) RenderThreadImpl gets destructed. MessageLoop gets destructed.
3) The workers may access the RenderThreadImpl and MessageLoop.

To fix the problem, we need to call ProcessDied() and forcibly kill the renderer
process at the end of RenderThreadImpl::Shutdown().
.

Powered by Google App Engine
This is Rietveld 408576698