Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2271933002: Updating It2Me to use the new ValidatingAuthenticator class (Closed)

Created:
4 years, 4 months ago by joedow
Modified:
4 years, 3 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@authenticator
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating It2Me to use the new ValidatingAuthenticator class This change moves the connection validation logic for It2Me from the host factory and into a callback in the It2Mehost class. A subsequent change will move the confirmation dialog into this new method as well but that is a larger change and I wanted to keep the initial change small. BUG=617185 Committed: https://crrev.com/9816b437d44dbaf5d9571216bb0b21bb6dc452bd Cr-Commit-Position: refs/heads/master@{#415774}

Patch Set 1 #

Patch Set 2 : Unittests! #

Patch Set 3 : Cleaning up the unit tests and the mechanism used for validating the JID #

Patch Set 4 : Fixing a build break #

Patch Set 5 : Cleanup prior to CR #

Total comments: 4

Patch Set 6 : Addressing feedback #

Patch Set 7 : Fixing a race condition in a unittest #

Patch Set 8 : Merging upstream changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -45 lines) Patch
M remoting/host/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/it2me/it2me_host.h View 1 2 3 4 5 4 chunks +21 lines, -0 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 1 2 3 4 5 8 chunks +56 lines, -9 lines 0 comments Download
A remoting/host/it2me/it2me_host_unittest.cc View 1 2 3 4 5 6 7 1 chunk +168 lines, -0 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.h View 3 chunks +7 lines, -5 lines 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.cc View 1 2 3 3 chunks +14 lines, -24 lines 0 comments Download
M remoting/signaling/jid_util.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 35 (29 generated)
joedow
PTAL! Thanks, Joe
4 years, 3 months ago (2016-08-26 22:52:11 UTC) #13
Jamie
lgtm https://codereview.chromium.org/2271933002/diff/100001/remoting/host/it2me/it2me_host.h File remoting/host/it2me/it2me_host.h (right): https://codereview.chromium.org/2271933002/diff/100001/remoting/host/it2me/it2me_host.h#newcode204 remoting/host/it2me/it2me_host.h:204: // Called after the client machine initiates the ...
4 years, 3 months ago (2016-08-26 23:31:02 UTC) #14
joedow
Thanks! https://codereview.chromium.org/2271933002/diff/100001/remoting/host/it2me/it2me_host.h File remoting/host/it2me/it2me_host.h (right): https://codereview.chromium.org/2271933002/diff/100001/remoting/host/it2me/it2me_host.h#newcode204 remoting/host/it2me/it2me_host.h:204: // Called after the client machine initiates the ...
4 years, 3 months ago (2016-08-30 00:08:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271933002/160001
4 years, 3 months ago (2016-08-31 22:02:51 UTC) #32
commit-bot: I haz the power
Committed patchset #8 (id:160001)
4 years, 3 months ago (2016-08-31 22:09:34 UTC) #33
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:11:24 UTC) #35
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/9816b437d44dbaf5d9571216bb0b21bb6dc452bd
Cr-Commit-Position: refs/heads/master@{#415774}

Powered by Google App Engine
This is Rietveld 408576698