pkg/scheduled_test: handle null currentSchedule due to timeout

pkg/scheduled_test/test/metatest.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// A test library for testing test libraries? We must go deeper.
 ///
 /// Since unit testing code tends to use a lot of global state, it can be tough
 /// to test. This library manages it by running each test case in a child
 /// isolate, then reporting the results back to the parent isolate.
 library metatest;
@@ skipping 35 matching lines @@
 
         fail('Expected exactly ${stringify(shouldPass)} to pass, but '
             '${stringify(didPass)} passed.\n'
             '${_summarizeTests(results)}');
       }
     }
   });
 }
 
 /// Declares a test with the given [description] and [body]. [body] corresponds
+/// to the `main` method of a test file, and will be run in an isolate.

[nweiz, 2014/04/08 19:27:36]

One-sentence first paragraph.

[kevmoo, 2014/04/08 20:17:51]

Done.

+///
+/// All tests must have an expected result in [expectedResults].
+void expectTests(String description, void body(),
+                 Map<String, String> expectedResults) {

[nweiz, 2014/04/08 19:27:36]

This never calls [_summarizeTests], which means that the error output will
likely be difficult to understand. Rather than using [expect] at all, consider
following [expectTestsPass] and calling [fail] explicitly.

[kevmoo, 2014/04/08 20:17:51]

I added _summarizeTests to each reason: output, which should help

+

[nweiz, 2014/04/08 19:27:36]

Nit: unnecessary newline.

[kevmoo, 2014/04/08 20:17:51]

Done.

+  _setUpTest(description, body, (results) {
+    expectedResults = new Map.from(expectedResults);
+
+    for (var t in results['results']) {

[nweiz, 2014/04/08 19:27:36]

Nit: Use actual words for variables, not single characters.

[kevmoo, 2014/04/08 20:17:51]

Done.

+      var description = t['description'];
+
+      var expectedResult = expectedResults.remove(description);
+      expect(expectedResult, isNotNull,
+          reason: '"$description" did not have an expected result set.');

[nweiz, 2014/04/08 19:27:36]

Instead of this, use `expect(expectedResults, containsKey(description))`.  That
will produce a nicer error message automatically.

[kevmoo, 2014/04/08 20:17:51]

Done.

+
+      var result = t['result'];
+
+      expect(result, expectedResult,
+          reason: 'The test "$description" not not have the expected result.');

[nweiz, 2014/04/08 19:27:36]

expect(t, containsPair('result', expectedResult))

[kevmoo, 2014/04/08 20:17:51]

Done.

+    }
+    expect(expectedResults, isEmpty);

[nweiz, 2014/04/08 19:27:36]

reason: "Unexpected additional test results."

[kevmoo, 2014/04/08 20:17:51]

Done.

+  });
+}
+
+/// Declares a test with the given [description] and [body]. [body] corresponds
 /// to the `main` method of a test file, and will be run in an isolate. Expects
 /// all tests defined by [body] to fail.
 void expectTestsFail(String description, void body()) {
   _setUpTest(description, body, (results) {
     if (_hasError(results)) {
       throw 'Expected all tests to fail, but got error(s):\n'
           '${_summarizeTests(results)}';
     } else if (results['passed'] != 0) {
       throw 'Expected all tests to fail, but some passed:\n'
           '${_summarizeTests(results)}';
@@ skipping 136 matching lines @@
       "uncaughtError": uncaughtError,
       "results": results.map((testCase) => {
         "description": testCase.description,
         "message": testCase.message,
         "result": testCase.result,
         "stackTrace": testCase.stackTrace.toString()
       }).toList()
     });
   }
 }