pkg/scheduled_test: handle null currentSchedule due to timeout

pkg/scheduled_test/lib/scheduled_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(nweiz): Add support for calling [schedule] while the schedule is already
 // running.
 // TODO(nweiz): Port the non-Pub-specific scheduled test libraries from Pub.
 /// A package for writing readable tests of asynchronous behavior.
 ///
 /// ## Installing ##
@@ skipping 215 matching lines @@
 /// [unittest.solo_test].
 void solo_test(String description, void body()) =>
   _test(description, body, unittest.solo_test);
 
 void _test(String description, void body(), Function testFn) {
   unittest.ensureInitialized();
   _ensureSetUpForTopLevel();
   testFn(description, () {
     var completer = new Completer();
 
+    var errorHandler;

[nweiz, 2014/04/08 19:27:36]

Add a comment: "Capture this in a local variable in case we capture an
out-of-band error after the schedule completes."

[kevmoo, 2014/04/08 20:17:51]

Done.

+
     Chain.capture(() {
       _currentSchedule = new Schedule();
+      errorHandler = _currentSchedule.signalError;
       return currentSchedule.run(() {
         if (_setUpFn != null) _setUpFn();
         body();
       }).catchError((error, stackTrace) {
         if (error is ScheduleError) {
           assert(error.schedule.errors.contains(error));
           assert(error.schedule == currentSchedule);
           unittest.registerException(error.schedule.errorString());
         } else {
           unittest.registerException(error, new Chain.forTrace(stackTrace));
         }
       }).then(completer.complete);
-    }, onError: (error, chain) => currentSchedule.signalError(error, chain));
+    }, onError: errorHandler);

[nweiz, 2014/04/09 01:20:41]

I figured out the issue: this is being passed in when [errorHandler] is still
null. Just write "(error, stackTrace) => errorHandler(error, stackTrace)" and
it's all good.

 
     return completer.future;
   });
 }
 
 /// Whether or not the tests currently being defined are in a group. This is
 /// only true when defining tests, not when executing them.
 bool _inGroup = false;
 
 /// Creates a new named group of tests. This has the same semantics as
@@ skipping 106 matching lines @@
 /// [description] provides an optional description of the future, which is
 /// used when generating error messages.
 Future wrapFuture(Future future, [String description]) {
   if (currentSchedule == null) {
     throw new StateError("Unexpected call to wrapFuture with no current "
         "schedule.");
   }
 
   return currentSchedule.wrapFuture(future, description);
 }