Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2271923002: Remove the Offline snackbar flag check. (Closed)

Created:
4 years, 4 months ago by carlosk
Modified:
4 years, 4 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Offline snackbar flag check. The Offline snackbar is not showing as expected when Offline pages are loaded and the user goes back online. Let's try removing the initial flag check as the following checks should already be enough (unless something else breaks). BUG=640681 Committed: https://crrev.com/73c52ce70747025ffed61d191fa8008314925d95 Cr-Commit-Position: refs/heads/master@{#414109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
carlosk
fgorski@ PTAL.
4 years, 4 months ago (2016-08-24 18:01:28 UTC) #6
dewittj
drive-by: needs a bug, especially since this sounds like a speculative fix.
4 years, 4 months ago (2016-08-24 18:02:33 UTC) #7
fgorski
lgtm
4 years, 4 months ago (2016-08-24 18:04:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271923002/1
4 years, 4 months ago (2016-08-24 18:09:22 UTC) #12
carlosk
On 2016/08/24 18:02:33, dewittj wrote: > drive-by: needs a bug, especially since this sounds like ...
4 years, 4 months ago (2016-08-24 18:12:50 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 18:23:11 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 18:26:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73c52ce70747025ffed61d191fa8008314925d95
Cr-Commit-Position: refs/heads/master@{#414109}

Powered by Google App Engine
This is Rietveld 408576698