Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1873)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java

Issue 2271913002: [Downloads] Remove externally deleted items from downloads history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [Downloads] Remove externally deleted items from downloads history Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
index bf62f9a7db7e1935e4fe0b7e9cce933db5175ae5..7c605d89ae2638c161342dc2c63af7f9f5c18201 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
@@ -9,6 +9,7 @@ import android.support.annotation.Nullable;
import android.support.v4.widget.DrawerLayout;
import android.util.AttributeSet;
+import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.download.ui.DownloadManagerUi.DownloadUiObserver;
import org.chromium.chrome.browser.widget.selection.SelectionDelegate;
@@ -47,8 +48,14 @@ public class DownloadManagerToolbar extends SelectionToolbar<DownloadHistoryItem
@Override
public void onSelectionStateChange(List<DownloadHistoryItemWrapper> selectedItems) {
+ boolean wasSelectionEnabled = mIsSelectionEnabled;
super.onSelectionStateChange(selectedItems);
+
if (!mIsSelectionEnabled) updateTitle();
+
+ if (mIsSelectionEnabled && !wasSelectionEnabled) {
qinmin 2016/08/24 16:30:53 nit: mIsSelectEnabled appeared twice in the condit
Theresa 2016/08/24 22:52:09 Done.
+ RecordUserAction.record("Android.DownloadManager.SelectionEstablished");
+ }
}
@Override

Powered by Google App Engine
This is Rietveld 408576698