chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java - Issue 2271913002: [Downloads] Remove externally deleted items from downloads history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

Issue 2271913002: [Downloads] Remove externally deleted items from downloads history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: dfalcantara@ review changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java ('k') | chrome/browser/android/download/download_manager_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

index 1bda3e2219da5c8c2d466093d6f528f0d3c0f72b..2e1b06f8483f0b98084d554f92171a052401242a 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java

@@ -254,7 +254,8 @@ public class DownloadActivityTest extends BaseActivityInstrumentationTestCase<Do

// Click the delete button, which should delete the items and reset the toolbar.

assertEquals(11, mAdapter.getItemCount());

- assertEquals(0,

+ // checkForExternallyRemovedFiles() should have been called once already in onResume().

+ assertEquals(1,

mStubbedProvider.getDownloadDelegate().checkExternalCallback.getCallCount());

assertEquals(0,

mStubbedProvider.getDownloadDelegate().removeDownloadCallback.getCallCount());