Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java

Issue 2271913002: [Downloads] Remove externally deleted items from downloads history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dfalcantara@ review changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
index 0a131dc1adc369763e59bd06e5ae4d8b7e021cf4..64e9d06b5ef2c7d13de66cf53b38c371e8a9ef4f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
@@ -9,6 +9,7 @@ import android.support.annotation.Nullable;
import android.support.v4.widget.DrawerLayout;
import android.util.AttributeSet;
+import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.download.ui.DownloadManagerUi.DownloadUiObserver;
import org.chromium.chrome.browser.widget.selection.SelectionDelegate;
@@ -49,7 +50,9 @@ public class DownloadManagerToolbar extends SelectionToolbar<DownloadHistoryItem
@Override
public void onSelectionStateChange(List<DownloadHistoryItemWrapper> selectedItems) {
+ boolean wasSelectionEnabled = mIsSelectionEnabled;
super.onSelectionStateChange(selectedItems);
+
if (!mIsSelectionEnabled) {
updateTitle();
} else {
@@ -60,6 +63,10 @@ public class DownloadManagerToolbar extends SelectionToolbar<DownloadHistoryItem
findViewById(R.id.selection_mode_delete_menu_id).setContentDescription(
getResources().getQuantityString(R.plurals.accessibility_remove_selected_items,
numSelected, numSelected));
+
+ if (!wasSelectionEnabled) {
+ RecordUserAction.record("Android.DownloadManager.SelectionEstablished");
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698