Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: content/browser/accessibility/ax_platform_position.h

Issue 2271893002: Creates AXPosition to uniquely identify a position in the accessibility tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-wrote implementation to include tree_id and platform specific AXPosition. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/ax_platform_position.h
diff --git a/content/browser/accessibility/ax_platform_position.h b/content/browser/accessibility/ax_platform_position.h
new file mode 100644
index 0000000000000000000000000000000000000000..5a31ad4c3f8a07b90ad1a32873b22d10b59a0bbd
--- /dev/null
+++ b/content/browser/accessibility/ax_platform_position.h
@@ -0,0 +1,39 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_ACCESSIBILITY_AX_PLATFORM_POSITION_H_
+#define CONTENT_BROWSER_ACCESSIBILITY_AX_PLATFORM_POSITION_H_
+
+#include <stdint.h>
+
+#include "content/browser/accessibility/ax_tree_id_registry.h"
+#include "content/browser/accessibility/browser_accessibility.h"
+#include "content/browser/accessibility/browser_accessibility_manager.h"
+#include "ui/accessibility/ax_node.h"
+#include "ui/accessibility/ax_position.h"
+
+namespace content {
+
+class AXPlatformPosition : AXPosition {
+ public:
+ ~AXPlatformPosition() override;
+
+ ui::AXTextAffinity get_affinity() { return affinity_; }
dmazzoni 2016/10/03 18:22:51 I think this needs to be part of AXPosition. It w
+ void set_affinity(ui::AXTextAffinity affinity) { affinity_ = affinity; }
+
+ protected:
+ AXPlatformPosition(AXTreeIDRegistry::AXTreeID tree_id, int32_t anchor_id, int child_index, int text_offset, AXPositionType type);
+
+ BrowserAccessibility* GetPlatformNodeInTree(AXTreeIDRegistry::AXTreeID tree_id, int32-t node_id) const;
+ AXNode* GetNodeInTree(AXTreeIDRegistry::AXTreeID tree_id, int32-t node_id) const override;
+ int MaxTextOffset() const override;
+
+ private:
+ // TODO(nektar): Get rid of affinity and make Blink handle affinity internally.
+ ui::AXTextAffinity affinity;
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_ACCESSIBILITY_AX_PLATFORM_POSITION_H_

Powered by Google App Engine
This is Rietveld 408576698