Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2271883002: Fix paint invalidation and painting for composited-scrolling input elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index 1c356515a000fbe6f1ef14f2e71e5212e912f078..18efa1b515f20432f4eb909d28356cb962aaf0a3 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -1470,10 +1470,6 @@ void PaintLayerScrollableArea::updateCompositingLayersAfterScroll()
bool PaintLayerScrollableArea::usesCompositedScrolling() const
{
- // Scroll form controls on the main thread so they exhibit correct touch scroll event bubbling
- if (box().isIntrinsicallyScrollable(VerticalScrollbar) || box().isIntrinsicallyScrollable(HorizontalScrollbar))
- return false;
-
// See https://codereview.chromium.org/176633003/ for the tests that fail without this disabler.
DisableCompositingQueryAsserts disabler;
return layer()->hasCompositedLayerMapping() && layer()->compositedLayerMapping()->scrollingLayer();
@@ -1481,6 +1477,10 @@ bool PaintLayerScrollableArea::usesCompositedScrolling() const
bool PaintLayerScrollableArea::shouldScrollOnMainThread() const
{
+ // Scroll form controls on the main thread so they exhibit correct touch scroll event bubbling
bokan 2016/08/26 15:38:32 This comment is backwards now since we return "don
chrishtr 2016/08/26 15:42:36 Done.
+ if (box().isIntrinsicallyScrollable(VerticalScrollbar) || box().isIntrinsicallyScrollable(HorizontalScrollbar))
+ return false;
+
if (LocalFrame* frame = box().frame()) {
if (Page* page = frame->page()) {
if (page->scrollingCoordinator()->shouldUpdateScrollLayerPositionOnMainThread())

Powered by Google App Engine
This is Rietveld 408576698