Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.h

Issue 2271883002: Fix paint invalidation and painting for composited-scrolling input elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CaretBase.h
diff --git a/third_party/WebKit/Source/core/editing/CaretBase.h b/third_party/WebKit/Source/core/editing/CaretBase.h
index a69b67a91728c8b64ad8b3391916e82c68ca5a17..ea53653aa3ae662ddfe13a1dbf129dae0974efdc 100644
--- a/third_party/WebKit/Source/core/editing/CaretBase.h
+++ b/third_party/WebKit/Source/core/editing/CaretBase.h
@@ -30,11 +30,13 @@
#include "core/editing/VisiblePosition.h"
#include "platform/geometry/IntRect.h"
#include "platform/geometry/LayoutRect.h"
+#include "platform/graphics/paint/DisplayItem.h"
#include "wtf/Noncopyable.h"
namespace blink {
class CullRect;
+class DisplayItemClient;
class LocalFrame;
class GraphicsContext;
class LayoutBlock;
@@ -58,7 +60,7 @@ public:
IntRect absoluteBoundsForLocalRect(Node*, const LayoutRect&) const;
bool shouldRepaintCaret(Node&) const;
bool shouldRepaintCaret(const LayoutViewItem) const;
- void paintCaret(Node*, GraphicsContext&, const LayoutPoint&) const;
+ void paintCaret(Node*, GraphicsContext&, const LayoutPoint&, DisplayItem::Type) const;
const LayoutRect& localCaretRectWithoutUpdate() const { return m_caretLocalRect; }
@@ -72,6 +74,8 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
+ static DisplayItemClient* displayItemClientForCaret(Node*);
+
LayoutRect m_caretLocalRect; // caret rect in coords local to the layoutObject responsible for painting the caret
CaretVisibility m_caretVisibility;
};

Powered by Google App Engine
This is Rietveld 408576698