Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: git_cl.py

Issue 2271873003: Remove --base_url from git cl and upload.py (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/upload.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 42a5eabc18207e364575959ab1d420de7f6f9f12..55664f934b3a9dc6d01140bb6081bc35acf6322c 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -2013,7 +2013,6 @@ class _RietveldChangelistImpl(_ChangelistCodereviewBase):
remote_url = '%s@%s' % (self.GetRemoteUrl(),
self.GetUpstreamBranch().split('/')[-1])
if remote_url:
- upload_args.extend(['--base_url', remote_url])
tandrii(chromium) 2016/08/24 11:22:07 i think remote_url isn't used any more. Can you re
agable 2016/08/24 16:53:43 Yeah, I tried, and it makes surprising tests fail
remote, remote_branch = self.GetRemoteBranch()
target_ref = GetTargetRef(remote, remote_branch, options.target_branch,
settings.GetPendingRefPrefix())
« no previous file with comments | « no previous file | third_party/upload.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698