Settings People: Add /signOut route for Disconnect dialog.

chrome/browser/resources/settings/route.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /**
    * Class for navigable routes. May only be instantiated within this file.
    * @constructor
    * @param {string} path
    * @private
@@ skipping 73 matching lines @@
   };
 
   // Abbreviated variable for easier definitions.
   var r = Route;
 
   // Root pages.
   r.BASIC = new Route('/');
   r.ADVANCED = new Route('/advanced');
   r.ABOUT = new Route('/help');
 
+  // Navigable dialogs. These are the only non-section children of root pages.

[michaelpg, 2016/08/24 20:19:04]

http://i.imgur.com/DJ2rRWK.gif
http://i.imgur.com/Qv1LZJx.jpg

+  // These are disfavored. If we add anymore, we should add explicit support.

[michaelpg, 2016/08/24 20:19:04]

http://i.imgur.com/nTyP9mc.gifv
http://i.imgur.com/y81sPgR.gif
How many should we have? http://i.imgur.com/aRlP2ef.gifv
http://i.imgur.com/HxIUSGb.gif

+  r.SIGN_OUT = r.BASIC.createChild('/signOut');
+  r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild('/clearBrowserData');
+
 <if expr="chromeos">
   r.INTERNET = r.BASIC.createSection('/internet', 'internet');
   r.NETWORK_DETAIL = r.INTERNET.createChild('/networkDetail');
   r.KNOWN_NETWORKS = r.INTERNET.createChild('/knownNetworks');
 </if>
 
   r.APPEARANCE = r.BASIC.createSection('/appearance', 'appearance');
   r.FONTS = r.APPEARANCE.createChild('/fonts');
 
   r.DEFAULT_BROWSER =
@@ skipping 17 matching lines @@
   r.DEVICE = r.BASIC.createSection('/device', 'device');
   r.POINTERS = r.DEVICE.createChild('/pointer-overlay');
   r.KEYBOARD = r.DEVICE.createChild('/keyboard-overlay');
   r.DISPLAY = r.DEVICE.createChild('/display');
   r.NOTES = r.DEVICE.createChild('/note');
 </if>
 
   r.PRIVACY = r.ADVANCED.createSection('/privacy', 'privacy');
   r.CERTIFICATES = r.PRIVACY.createChild('/certificates');
 
-  // CLEAR_BROWSER_DATA is the only navigable dialog route. It's the only child
-  // of a root page that's not a section. Don't add any more routes like these.
-  // If more navigable dialogs are needed, add explicit support in Route.

[michaelpg, 2016/08/24 20:19:04]

http://i.imgur.com/VQlWOGM.jpg
http://i.imgur.com/6mSDbZZ.gif
http://i.imgur.com/nfQ4Zkg.gif

-  r.CLEAR_BROWSER_DATA = r.ADVANCED.createChild('/clearBrowserData');
-
   r.SITE_SETTINGS = r.PRIVACY.createChild('/siteSettings');
   r.SITE_SETTINGS_ALL = r.SITE_SETTINGS.createChild('all');
   r.SITE_SETTINGS_SITE_DETAILS =
       r.SITE_SETTINGS_ALL.createChild('/siteSettings/siteDetails');
 
   r.SITE_SETTINGS_HANDLERS = r.SITE_SETTINGS.createChild('handlers');
 
   // TODO(tommycli): Find a way to refactor these repetitive category routes.
   r.SITE_SETTINGS_AUTOMATIC_DOWNLOADS =
       r.SITE_SETTINGS.createChild('automaticDownloads');
@@ skipping 195 matching lines @@
     Route: Route,
     RouteObserverBehavior: RouteObserverBehavior,
     getRouteForPath: getRouteForPath,
     initializeRouteFromUrl: initializeRouteFromUrl,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
     navigateTo: navigateTo,
     navigateToPreviousRoute: navigateToPreviousRoute,
   };
 });