Settings People: Add /signOut route for Disconnect dialog.

Settings People: Add /signOut route for Disconnect dialog.

BUG=640199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/54a670192c726f5762109842c0ecc958ad045256
Cr-Commit-Position: refs/heads/master@{#414562}

[tommycli, 2016-08-23 21:04:33]

Description was changed from

==========
Settings People: Add /signOut route for Disconnect dialog.

BUG=640199
==========

to

==========
Settings People: Add /signOut route for Disconnect dialog.

BUG=640199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-23 21:05:17]

tommycli@chromium.org changed reviewers:
+ michaelpg@chromium.org

[tommycli, 2016-08-23 21:05:18]

michaelpg: PTAL. I know you don't like these. Sorry

[michaelpg, 2016-08-24 20:19:04]

I really don't think we nee..... http://i.imgur.com/MdlRuJW.gif

On 2016/08/23 21:05:18, tommycli wrote:
> michaelpg: PTAL.

http://i.imgur.com/JMgTUL9.gifv

> I know you don't like these.

http://i.imgur.com/8F7uILw.gifv

> Sorry

http://i.imgur.com/kbzgOc7.gifv

Well http://i.imgur.com/riFw1Cx.gifv but http://i.imgur.com/FfxHb1o.gifv.

But for what it is, CL as written LGTM.

https://codereview.chromium.org/2271843002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/route.js (left):

https://codereview.chromium.org/2271843002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:133: // If more navigable dialogs are
needed, add explicit support in Route.
> Don't add any more routes like these.

http://i.imgur.com/VQlWOGM.jpg

> If more navigable dialogs are needed,

http://i.imgur.com/6mSDbZZ.gif

> add explicit support in Route.

http://i.imgur.com/nfQ4Zkg.gif

https://codereview.chromium.org/2271843002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2271843002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:94: // Navigable dialogs. These are
the only non-section children of root pages.
> Navigable dialogs

http://i.imgur.com/DJ2rRWK.gif

> These are the only non-section children of root pages.

http://i.imgur.com/Qv1LZJx.jpg

https://codereview.chromium.org/2271843002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:95: // These are disfavored. If we
add anymore, we should add explicit support.
http://i.imgur.com/nTyP9mc.gifv

> These are disfavored.

http://i.imgur.com/y81sPgR.gif

> If we add anymore,

How many should we have? http://i.imgur.com/aRlP2ef.gifv

> we should add explicit support.

http://i.imgur.com/HxIUSGb.gif

[tommycli, 2016-08-24 20:37:33]

michaelpg: lol so many memes. Thanks!

[tommycli, 2016-08-24 20:37:39]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:38:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:56:25]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-08-24 22:01:33]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 22:22:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:22:34]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-08-25 16:55:08]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-25 16:55:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:13:00]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tommycli, 2016-08-25 18:32:15]

Description was changed from

==========
Settings People: Add /signOut route for Disconnect dialog.

BUG=640199
==========

to

==========
Settings People: Add /signOut route for Disconnect dialog.

BUG=640199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-25 18:34:37]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-25 18:34:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2271843002/#ps20001
(title: "update test")

[commit-bot: I haz the power, 2016-08-25 18:35:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 19:56:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 19:56:54]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tommycli, 2016-08-25 21:03:10]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-25 21:05:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:36:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 22:39:26]

Description was changed from

==========
Settings People: Add /signOut route for Disconnect dialog.

BUG=640199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People: Add /signOut route for Disconnect dialog.

BUG=640199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/54a670192c726f5762109842c0ecc958ad045256
Cr-Commit-Position: refs/heads/master@{#414562}
==========

[commit-bot: I haz the power, 2016-08-25 22:39:27]

Patchset 2 (id:??) landed as
https://crrev.com/54a670192c726f5762109842c0ecc958ad045256
Cr-Commit-Position: refs/heads/master@{#414562}

[jianli, 2016-08-26 00:23:39]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2279883004/ by jianli@chromium.org.

The reason for reverting is: The following browser test failed:
 CrSettingsPeoplePageTest.PeoplePage

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2....