[wasm] Bound the allowed number of locals.

[wasm] Bound the allowed number of locals.

This CL fixes the first bug I found with the new fuzzing. The problem is
that the number of locals is unbounded. This CL bounds the number of
locals of one type with 8000000, an arbitrary number.

R=titzer@chromium.org
BUG=

Committed: https://crrev.com/71f93e6001195a7f70ecf449af9d894ead57d297
Cr-Commit-Position: refs/heads/master@{#38936}

[ahaas, 2016-08-25 06:58:19]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 06:58:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 07:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 07:11:27]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[ahaas, 2016-08-25 07:39:35]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 07:39:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-08-25 07:40:16]

Description was changed from

==========
[wasm] Bound the allowed number of locals.

This CL fixes the first bug I found with the new fuzzing. The problem is
that the number of locals is unbounded. This CL bounds the number of
locals of one type with 10000, an arbitrary number.

R=titzer@chromium.org
BUG=
==========

to

==========
[wasm] Bound the allowed number of locals.

This CL fixes the first bug I found with the new fuzzing. The problem is
that the number of locals is unbounded. This CL bounds the number of
locals of one type with 8000000, an arbitrary number.

R=titzer@chromium.org
BUG=
==========

[ahaas, 2016-08-25 07:40:42]

On 2016/08/25 at 07:40:16, ahaas wrote:
> Description was changed from
> 
> ==========
> [wasm] Bound the allowed number of locals.
> 
> This CL fixes the first bug I found with the new fuzzing. The problem is
> that the number of locals is unbounded. This CL bounds the number of
> locals of one type with 10000, an arbitrary number.
> 
> R=titzer@chromium.org
> BUG=
> ==========
> 
> to
> 
> ==========
> [wasm] Bound the allowed number of locals.
> 
> This CL fixes the first bug I found with the new fuzzing. The problem is
> that the number of locals is unbounded. This CL bounds the number of
> locals of one type with 8000000, an arbitrary number.
> 
> R=titzer@chromium.org
> BUG=
> ==========

I changed the limit to 8000000, because one test wants that number to work.

[commit-bot: I haz the power, 2016-08-25 07:59:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 07:59:28]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-08-25 08:00:27]

lgtm with comment

https://codereview.chromium.org/2271803004/diff/20001/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2271803004/diff/20001/src/wasm/ast-decoder.cc...
src/wasm/ast-decoder.cc:667: if (count > 8000000) {
Can you introduce a constant in ast-decoder.h and make the test check for counts
around that number?

[ahaas, 2016-08-26 08:10:48]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 08:10:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-08-26 08:16:53]

On 2016/08/25 at 08:00:27, titzer wrote:
> lgtm with comment
> 
> https://codereview.chromium.org/2271803004/diff/20001/src/wasm/ast-decoder.cc
> File src/wasm/ast-decoder.cc (right):
> 
>
https://codereview.chromium.org/2271803004/diff/20001/src/wasm/ast-decoder.cc...
> src/wasm/ast-decoder.cc:667: if (count > 8000000) {
> Can you introduce a constant in ast-decoder.h and make the test check for
counts around that number?

I added the constant and the tests now.

[commit-bot: I haz the power, 2016-08-26 08:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 08:35:53]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-08-26 09:10:21]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-08-26 09:10:22]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2271803004/#ps40001
(title: "Add a constant for the limit and test it.")

[commit-bot: I haz the power, 2016-08-26 09:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 09:13:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-26 09:13:28]

Description was changed from

==========
[wasm] Bound the allowed number of locals.

This CL fixes the first bug I found with the new fuzzing. The problem is
that the number of locals is unbounded. This CL bounds the number of
locals of one type with 8000000, an arbitrary number.

R=titzer@chromium.org
BUG=
==========

to

==========
[wasm] Bound the allowed number of locals.

This CL fixes the first bug I found with the new fuzzing. The problem is
that the number of locals is unbounded. This CL bounds the number of
locals of one type with 8000000, an arbitrary number.

R=titzer@chromium.org
BUG=

Committed: https://crrev.com/71f93e6001195a7f70ecf449af9d894ead57d297
Cr-Commit-Position: refs/heads/master@{#38936}
==========

[commit-bot: I haz the power, 2016-08-26 09:13:29]

Patchset 3 (id:??) landed as
https://crrev.com/71f93e6001195a7f70ecf449af9d894ead57d297
Cr-Commit-Position: refs/heads/master@{#38936}