Fix system tray focus on locked state screen

Fix system tray focus on locked state screen

When TrayBackgroundView has overridden the OnPaint method from its parent
class, it did not neither implement a new OnPaintFocus method nor calling
the one the parent class. So focus selection stopped working.

TEST=MANUAL
- Turn on Lock Screen by pressing ctrl+shift+L, then change focus by pressing
"tab". Check if system tray can be focused. Repeat this test by using
ash-md=experimental and ash-md=normal.

BUG=640246
Committed: https://crrev.com/5b836eb96a445e7ec886b7acac2bf3f87eefc56b
Cr-Commit-Position: refs/heads/master@{#414117}

[yiyix, 2016-08-24 16:05:47]

Description was changed from

==========
Fix system tray focus on locked state screen

BUG=640246
==========

to

==========
Fix system tray focus on locked state screen

When TrayBackgroundView has overridden the OnPaint method 
from its parent class, it did not neither implement a new 
OnPaintFocus method nor calling the one the parent class. 
So focus selection stopped working.

BUG=640246
==========

[yiyix, 2016-08-24 16:05:47]

yiyix@chromium.org changed reviewers:
+ warx@chromium.org

[yiyix, 2016-08-24 16:07:48]

yiyix@chromium.org changed reviewers:
+ tdanderson@chromium.org

[Qiang(Joe) Xu, 2016-08-24 16:18:25]

On 2016/08/24 16:07:48, yiyix wrote:

lgtm

[tdanderson, 2016-08-24 16:20:17]

https://codereview.chromium.org/2271763005/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_background_view.cc (right):

https://codereview.chromium.org/2271763005/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_background_view.cc:545:
ActionableView::OnPaint(canvas);
You should be able to just have a single call to the superclass at the top of
this function (immediately before line 541). Can you try that and verify it does
what you expect?

[yiyix, 2016-08-24 17:39:54]

On 2016/08/24 16:20:17, tdanderson wrote:
>
https://codereview.chromium.org/2271763005/diff/1/ash/common/system/tray/tray...
> File ash/common/system/tray/tray_background_view.cc (right):
> 
>
https://codereview.chromium.org/2271763005/diff/1/ash/common/system/tray/tray...
> ash/common/system/tray/tray_background_view.cc:545:
> ActionableView::OnPaint(canvas);
> You should be able to just have a single call to the superclass at the top of
> this function (immediately before line 541). Can you try that and verify it
does
> what you expect?

I verified the behavior with and without ash-md flag. I forget to mention it in
the description.

[yiyix, 2016-08-24 17:43:28]

Description was changed from

==========
Fix system tray focus on locked state screen

When TrayBackgroundView has overridden the OnPaint method 
from its parent class, it did not neither implement a new 
OnPaintFocus method nor calling the one the parent class. 
So focus selection stopped working.

BUG=640246
==========

to

==========
Fix system tray focus on locked state screen

When TrayBackgroundView has overridden the OnPaint method from its parent
class, it did not neither implement a new OnPaintFocus method nor calling
the one the parent class. So focus selection stopped working.

TEST=MANUAL
- Turn on Lock Screen by pressing ctrl+shift+L, then change focus by pressing
"tab". Check if system tray can be focused. Repeat this test by using 
ash-md=experimental and ash-md=normal.

BUG=640246
==========

[tdanderson, 2016-08-24 18:00:09]

lgtm

[yiyix, 2016-08-24 18:04:33]

The CQ bit was checked by yiyix@chromium.org

[yiyix, 2016-08-24 18:04:33]

The patchset sent to the CQ was uploaded after l-g-t-m from warx@chromium.org
Link to the patchset: https://codereview.chromium.org/2271763005/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-08-24 18:05:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 19:01:17]

Description was changed from

==========
Fix system tray focus on locked state screen

When TrayBackgroundView has overridden the OnPaint method from its parent
class, it did not neither implement a new OnPaintFocus method nor calling
the one the parent class. So focus selection stopped working.

TEST=MANUAL
- Turn on Lock Screen by pressing ctrl+shift+L, then change focus by pressing
"tab". Check if system tray can be focused. Repeat this test by using 
ash-md=experimental and ash-md=normal.

BUG=640246
==========

to

==========
Fix system tray focus on locked state screen

When TrayBackgroundView has overridden the OnPaint method from its parent
class, it did not neither implement a new OnPaintFocus method nor calling
the one the parent class. So focus selection stopped working.

TEST=MANUAL
- Turn on Lock Screen by pressing ctrl+shift+L, then change focus by pressing
"tab". Check if system tray can be focused. Repeat this test by using 
ash-md=experimental and ash-md=normal.

BUG=640246
==========

[commit-bot: I haz the power, 2016-08-24 19:01:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 19:03:25]

Description was changed from

==========
Fix system tray focus on locked state screen

When TrayBackgroundView has overridden the OnPaint method from its parent
class, it did not neither implement a new OnPaintFocus method nor calling
the one the parent class. So focus selection stopped working.

TEST=MANUAL
- Turn on Lock Screen by pressing ctrl+shift+L, then change focus by pressing
"tab". Check if system tray can be focused. Repeat this test by using 
ash-md=experimental and ash-md=normal.

BUG=640246
==========

to

==========
Fix system tray focus on locked state screen

When TrayBackgroundView has overridden the OnPaint method from its parent
class, it did not neither implement a new OnPaintFocus method nor calling
the one the parent class. So focus selection stopped working.

TEST=MANUAL
- Turn on Lock Screen by pressing ctrl+shift+L, then change focus by pressing
"tab". Check if system tray can be focused. Repeat this test by using
ash-md=experimental and ash-md=normal.

BUG=640246

Committed: https://crrev.com/5b836eb96a445e7ec886b7acac2bf3f87eefc56b
Cr-Commit-Position: refs/heads/master@{#414117}
==========

[commit-bot: I haz the power, 2016-08-24 19:03:26]

Patchset 2 (id:??) landed as
https://crrev.com/5b836eb96a445e7ec886b7acac2bf3f87eefc56b
Cr-Commit-Position: refs/heads/master@{#414117}