Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2271743003: Win: Fix printing selected pages with native dialog. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Win: Fix printing selected pages with native dialog. During the PDF to EMF conversion process, the converter only knows a page as the Nth page of the PDF, and no longer has the original page number. Remember the association, so the Windows printing code can figure out the actual page number after the conversion finishes. Fix nits and typos along the way. BUG=553446 Committed: https://crrev.com/40f42ffb7ff37e464a85b52ca615597eea449fa1 Cr-Commit-Position: refs/heads/master@{#414081}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -44 lines) Patch
M chrome/browser/printing/print_job.h View 1 4 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/printing/print_job.cc View 1 2 12 chunks +39 lines, -36 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Lei Zhang
There was a "Doh!" moment earlier in the day.
4 years, 3 months ago (2016-08-24 05:06:40 UTC) #6
scottmg
lgtm
4 years, 3 months ago (2016-08-24 15:22:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271743003/40001
4 years, 3 months ago (2016-08-24 15:31:54 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-24 15:36:52 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 15:40:09 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40f42ffb7ff37e464a85b52ca615597eea449fa1
Cr-Commit-Position: refs/heads/master@{#414081}

Powered by Google App Engine
This is Rietveld 408576698