include/core/SkTLazy.h - Issue 2271743002: Reland: Experimental parsing expression grammar (PEG) template library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTLazy.h

Issue 2271743002: Reland: Experimental parsing expression grammar (PEG) template library (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/core/SkTLazy.h

diff --git a/include/core/SkTLazy.h b/include/core/SkTLazy.h

index 31dce6085f96779c3137fc5bf4011766a91b31f4..cb08387bb9fe331ba6876b50685b7e1680ddc81c 100644

--- a/include/core/SkTLazy.h

+++ b/include/core/SkTLazy.h

@@ -99,8 +99,8 @@ public:

T* getMaybeNull() const { return fPtr; }

private:

- T* fPtr; // nullptr or fStorage

SkAlignedSTStorage<1, T> fStorage;

+ T* fPtr; // nullptr or fStorage

bungeman-skia 2016/08/24 15:04:20 Should we just land this separately since it's mor

f(malita) 2016/08/24 17:17:02 SGTM, I'll upload a separate CL.

};

/**

« experimental/svg/model/SkPEG.h ('K') | « gyp/svg.gyp ('k') | tests/SkPEGTest.cpp » ('j') | no next file with comments »