Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 2271683004: Revert of Support for custom primaries (Closed)

Created:
4 years, 4 months ago by sakal-chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support for custom primaries (patchset #7 id:120001 of https://codereview.chromium.org/2229953003/ ) Reason for revert: Causes a crash in WebRtcApprtcBrowserTest.MANUAL_FirefoxApprtcInteropTest. [72802:72802:0824/130437:FATAL:list_container_helper.cc(460)] Check failed: size_of_actual_element_in_bytes <= data_->element_size() (240 vs. 224) Original issue's description: > Support for custom primaries > > When converting an ICC profile to a ColorSpace, the primaries are extracted. > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba > Cr-Commit-Position: refs/heads/master@{#413914} TBR=ccameron@chromium.org,tsepez@chromium.org,hubbe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/07b0c0a38a4d33cd72af233db22b6fc51b65795a Cr-Commit-Position: refs/heads/master@{#414041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -132 lines) Patch
M cc/output/color_lut_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/largest_draw_quad.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/gfx/color_space.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/gfx/color_transform.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_transform.cc View 2 chunks +3 lines, -17 lines 0 comments Download
M ui/gfx/color_transform_fuzzer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/color_transform_unittest.cc View 5 chunks +6 lines, -43 lines 0 comments Download
M ui/gfx/icc_profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/icc_profile.cc View 3 chunks +1 line, -47 lines 0 comments Download
M ui/gfx/ipc/color/gfx_param_traits.cc View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sakal-chromium
Created Revert of Support for custom primaries
4 years, 4 months ago (2016-08-24 11:11:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271683004/1
4 years, 4 months ago (2016-08-24 11:12:06 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-24 11:12:09 UTC) #5
sakal-chromium
Command line used to run the test: ./out/Debug/browser_tests --fast-local-dev --gtest_filter="*FirefoxApprtcInteropTest*" --run-manual --ui-test-action-max-timeout=150000
4 years, 4 months ago (2016-08-24 11:12:23 UTC) #7
sakal-chromium
PTAL
4 years, 4 months ago (2016-08-24 11:16:27 UTC) #9
magjed_chromium
lgtm
4 years, 4 months ago (2016-08-24 11:18:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271683004/1
4 years, 4 months ago (2016-08-24 11:18:51 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 11:19:45 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 11:21:46 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07b0c0a38a4d33cd72af233db22b6fc51b65795a
Cr-Commit-Position: refs/heads/master@{#414041}

Powered by Google App Engine
This is Rietveld 408576698