Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2271683003: DevTools: Move CodeMirrorTextEditor into text_editor module (Closed)

Created:
4 years, 3 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move CodeMirrorTextEditor into text_editor module This is in preperation for CodeMirror-based console BUG=607690 NOTRY=true Committed: https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1 Cr-Commit-Position: refs/heads/master@{#414740}

Patch Set 1 #

Patch Set 2 : Merge with SourcesTextEditor split #

Total comments: 2

Patch Set 3 : Remove factory from module.json #

Patch Set 4 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2733 lines) Patch
M third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 2 3 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 2 3 1 chunk +0 lines, -1628 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorUtils.js View 1 chunk +0 lines, -241 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js View 1 2 3 1 chunk +0 lines, -423 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css View 1 2 3 1 chunk +0 lines, -362 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/module.json View 1 2 chunks +2 lines, -47 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorUtils.js View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/text_editor/module.json View 1 2 4 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
einbinder
Ptal. Moving CodeMirrorTextEditor and related files into a text_editor module so in the future it ...
4 years, 3 months ago (2016-08-23 21:57:14 UTC) #2
lushnikov
https://codereview.chromium.org/2271683003/diff/20001/third_party/WebKit/Source/devtools/front_end/text_editor/module.json File third_party/WebKit/Source/devtools/front_end/text_editor/module.json (right): https://codereview.chromium.org/2271683003/diff/20001/third_party/WebKit/Source/devtools/front_end/text_editor/module.json#newcode9 third_party/WebKit/Source/devtools/front_end/text_editor/module.json:9: "className": "WebInspector.CodeMirrorTextEditorFactory" where is this factory?
4 years, 3 months ago (2016-08-24 22:03:06 UTC) #7
einbinder
ptal https://codereview.chromium.org/2271683003/diff/20001/third_party/WebKit/Source/devtools/front_end/text_editor/module.json File third_party/WebKit/Source/devtools/front_end/text_editor/module.json (right): https://codereview.chromium.org/2271683003/diff/20001/third_party/WebKit/Source/devtools/front_end/text_editor/module.json#newcode9 third_party/WebKit/Source/devtools/front_end/text_editor/module.json:9: "className": "WebInspector.CodeMirrorTextEditorFactory" On 2016/08/24 at 22:03:05, lushnikov wrote: ...
4 years, 3 months ago (2016-08-24 22:26:10 UTC) #8
lushnikov
lgtm
4 years, 3 months ago (2016-08-25 17:33:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271683003/60001
4 years, 3 months ago (2016-08-26 17:22:22 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-26 17:27:53 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:29:48 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3b39cdf5665a652c50824367829c2bbff8cdfdd1
Cr-Commit-Position: refs/heads/master@{#414740}

Powered by Google App Engine
This is Rietveld 408576698