Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2271673002: Reland #2 of Enable whitelist generation for official builds. (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Enable whitelist generation for official builds. Previous: https://codereview.chromium.org/2241383004/ Currently, all resources are included in PAK files when Chrome is built locally. Only official_buildbot.sh uses a resource whitelist. This CL enables local builds to use resource whitelisting by setting the enable_resource_whitelist_generation gn flag to true, or by building an official build. This will allow developers to more easily monitor the changes in APK size for each commit they make. However, a large amount of output is generated (_pragma is used to create warnings to allow whitelisted resources to be listed), so for now the whitelist will only be generated for official builds. This change results in a ~1.5 mb difference when calculating the APK size with resource_sizes.py. BUG=632385 Committed: https://crrev.com/c7e6104c8c2ed8080115e92ff3c6f9d748e7feae Cr-Commit-Position: refs/heads/master@{#413794}

Patch Set 1 #

Patch Set 2 : rebase + use shlib_extension instead of hardcoded value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -178 lines) Patch
M build/toolchain/gcc_ar_wrapper.py View 3 chunks +10 lines, -15 lines 0 comments Download
A build/toolchain/gcc_compile_wrapper.py View 1 chunk +44 lines, -0 lines 0 comments Download
M build/toolchain/gcc_solink_wrapper.py View 5 chunks +16 lines, -21 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 6 chunks +33 lines, -2 lines 0 comments Download
A build/toolchain/wrapper_utils.py View 1 chunk +105 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 4 chunks +41 lines, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/grit/grit/format/data_pack.py View 4 chunks +12 lines, -5 lines 0 comments Download
M tools/grit/grit/format/repack.py View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/grit/repack.gni View 2 chunks +6 lines, -10 lines 0 comments Download
D tools/resources/find_used_resources.py View 1 chunk +0 lines, -89 lines 0 comments Download
A + tools/resources/generate_resource_whitelist.py View 5 chunks +25 lines, -32 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
estevenson
ptal, the last attempt failed because I didn't realize that a different shared library extension ...
4 years, 4 months ago (2016-08-23 14:54:22 UTC) #2
agrieve
On 2016/08/23 14:54:22, estevenson wrote: > ptal, the last attempt failed because I didn't realize ...
4 years, 4 months ago (2016-08-23 14:58:02 UTC) #5
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-23 15:29:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271673002/20001
4 years, 4 months ago (2016-08-23 18:33:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 18:40:01 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c7e6104c8c2ed8080115e92ff3c6f9d748e7feae Cr-Commit-Position: refs/heads/master@{#413794}
4 years, 4 months ago (2016-08-23 18:42:48 UTC) #17
pkotwicz
4 years, 4 months ago (2016-08-23 22:21:13 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2277523002/ by pkotwicz@chromium.org.

The reason for reverting is: Breaking perf try bot
https://build.chromium.org/p/tryserver.chromium.perf/builders/android_perf_bi....

Powered by Google App Engine
This is Rietveld 408576698