base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc.

base/mac/mac_util_unittest.mm

Index: base/mac/mac_util_unittest.mm
diff --git a/base/mac/mac_util_unittest.mm b/base/mac/mac_util_unittest.mm
index 11003fa0bc557e58a296addd7e310d9ffda7080f..38d7d8cbb76aeb07e548ca4ed4ea7ff55e3ed9c1 100644
--- a/base/mac/mac_util_unittest.mm
+++ b/base/mac/mac_util_unittest.mm
@@ -146,49 +146,49 @@ TEST_F(MacUtilTest, IsOSEllipsis) {
 
   if (major == 10) {
     if (minor == 9) {

[Mark Mentovai, 2016/08/26 15:27:26]

Since you’re now defining the (pointless) IsAtLeastOS10_9, it should at least be
tested. And I guess IsAtMostOS10_12, too.

[Sidney San Martín, 2016/08/28 21:27:17]

Done. (But hopefully I can get rid of *OS10_9().)

-      EXPECT_TRUE(IsOSMavericks());
-      EXPECT_FALSE(IsOSYosemite());
-      EXPECT_TRUE(IsOSYosemiteOrEarlier());
-      EXPECT_FALSE(IsOSYosemiteOrLater());
-      EXPECT_FALSE(IsOSElCapitan());
-      EXPECT_TRUE(IsOSElCapitanOrEarlier());
-      EXPECT_FALSE(IsOSElCapitanOrLater());
-      EXPECT_FALSE(IsOSSierra());
-      EXPECT_FALSE(IsOSSierraOrLater());
-      EXPECT_FALSE(IsOSLaterThanSierra_DontCallThis());
+      EXPECT_TRUE(IsOS10_9());
+      EXPECT_FALSE(IsOS10_10());
+      EXPECT_TRUE(IsAtMostOS10_10());
+      EXPECT_FALSE(IsAtLeastOS10_10());
+      EXPECT_FALSE(IsOS10_11());
+      EXPECT_TRUE(IsAtMostOS10_11());
+      EXPECT_FALSE(IsAtLeastOS10_11());
+      EXPECT_FALSE(IsOS10_12());
+      EXPECT_FALSE(IsAtLeastOS10_12());
+      EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());
     } else if (minor == 10) {
-      EXPECT_FALSE(IsOSMavericks());
-      EXPECT_TRUE(IsOSYosemite());
-      EXPECT_TRUE(IsOSYosemiteOrEarlier());
-      EXPECT_TRUE(IsOSYosemiteOrLater());
-      EXPECT_FALSE(IsOSElCapitan());
-      EXPECT_TRUE(IsOSElCapitanOrEarlier());
-      EXPECT_FALSE(IsOSElCapitanOrLater());
-      EXPECT_FALSE(IsOSSierra());
-      EXPECT_FALSE(IsOSSierraOrLater());
-      EXPECT_FALSE(IsOSLaterThanSierra_DontCallThis());
+      EXPECT_FALSE(IsOS10_9());
+      EXPECT_TRUE(IsOS10_10());
+      EXPECT_TRUE(IsAtMostOS10_10());
+      EXPECT_TRUE(IsAtLeastOS10_10());
+      EXPECT_FALSE(IsOS10_11());
+      EXPECT_TRUE(IsAtMostOS10_11());
+      EXPECT_FALSE(IsAtLeastOS10_11());
+      EXPECT_FALSE(IsOS10_12());
+      EXPECT_FALSE(IsAtLeastOS10_12());
+      EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());
     } else if (minor == 11) {
-      EXPECT_FALSE(IsOSMavericks());
-      EXPECT_FALSE(IsOSYosemite());
-      EXPECT_FALSE(IsOSYosemiteOrEarlier());
-      EXPECT_TRUE(IsOSYosemiteOrLater());
-      EXPECT_TRUE(IsOSElCapitan());
-      EXPECT_TRUE(IsOSElCapitanOrEarlier());
-      EXPECT_TRUE(IsOSElCapitanOrLater());
-      EXPECT_FALSE(IsOSSierra());
-      EXPECT_FALSE(IsOSSierraOrLater());
-      EXPECT_FALSE(IsOSLaterThanSierra_DontCallThis());
+      EXPECT_FALSE(IsOS10_9());
+      EXPECT_FALSE(IsOS10_10());
+      EXPECT_FALSE(IsAtMostOS10_10());
+      EXPECT_TRUE(IsAtLeastOS10_10());
+      EXPECT_TRUE(IsOS10_11());
+      EXPECT_TRUE(IsAtMostOS10_11());
+      EXPECT_TRUE(IsAtLeastOS10_11());
+      EXPECT_FALSE(IsOS10_12());
+      EXPECT_FALSE(IsAtLeastOS10_12());
+      EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());
     } else if (minor == 12) {
-      EXPECT_FALSE(IsOSMavericks());
-      EXPECT_FALSE(IsOSYosemite());
-      EXPECT_FALSE(IsOSYosemiteOrEarlier());
-      EXPECT_TRUE(IsOSYosemiteOrLater());
-      EXPECT_FALSE(IsOSElCapitan());
-      EXPECT_FALSE(IsOSElCapitanOrEarlier());
-      EXPECT_TRUE(IsOSElCapitanOrLater());
-      EXPECT_TRUE(IsOSSierra());
-      EXPECT_TRUE(IsOSSierraOrLater());
-      EXPECT_FALSE(IsOSLaterThanSierra_DontCallThis());
+      EXPECT_FALSE(IsOS10_9());
+      EXPECT_FALSE(IsOS10_10());
+      EXPECT_FALSE(IsAtMostOS10_10());
+      EXPECT_TRUE(IsAtLeastOS10_10());
+      EXPECT_FALSE(IsOS10_11());
+      EXPECT_FALSE(IsAtMostOS10_11());
+      EXPECT_TRUE(IsAtLeastOS10_11());
+      EXPECT_TRUE(IsOS10_12());
+      EXPECT_TRUE(IsAtLeastOS10_12());
+      EXPECT_FALSE(IsOSLaterThan10_12_DontCallThis());
     } else {
       // Not nine, ten, eleven, or twelve. Ah, ah, ah.
       EXPECT_TRUE(false);