ui/views/controls/menu/menu_config_mac.mm - Issue 2271653006: base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_config_mac.mm

Issue 2271653006: base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_config_mac.mm

diff --git a/ui/views/controls/menu/menu_config_mac.mm b/ui/views/controls/menu/menu_config_mac.mm

index 2e00665c377a99439b77eb0c48b184187fd16cf3..fc66f894436da1b5049280ff7dcbb2e07a8db186 100644

--- a/ui/views/controls/menu/menu_config_mac.mm

+++ b/ui/views/controls/menu/menu_config_mac.mm

@@ -31,9 +31,8 @@ void MenuConfig::Init() {

separator_height = 13;

separator_upper_height = 7;

separator_lower_height = 6;

- separator_thickness = base::mac::IsOSMavericks()

- ? kMenuSeparatorHeightMavericks

- : kMenuSeparatorHeight;

+ separator_thickness = base::mac::IsOS10_9() ? kMenuSeparatorHeightMavericks

+ : kMenuSeparatorHeight;

align_arrow_and_shortcut = true;

icons_in_label = true;

check_selected_combobox_item = true;

« no previous file with comments | « ui/views/cocoa/bridged_native_widget.mm ('k') | no next file » | no next file with comments »