ui/gfx/mac/io_surface.cc - Issue 2271653006: base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/mac/io_surface.cc

Issue 2271653006: base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/mac/io_surface.cc

diff --git a/ui/gfx/mac/io_surface.cc b/ui/gfx/mac/io_surface.cc

index 13b65aad740039f03fc98d58541ad9a34b40756a..3560790b28138f1b11f1145ec5024cd31562edc6 100644

--- a/ui/gfx/mac/io_surface.cc

+++ b/ui/gfx/mac/io_surface.cc

@@ -164,7 +164,7 @@ IOSurfaceRef CreateIOSurface(const gfx::Size& size, gfx::BufferFormat format) {

// https://crbug.com/594343.

// IOSurface clearing causes significant performance regression on about half

// of all devices running Yosemite. https://crbug.com/606850#c22.

- bool should_clear = !base::mac::IsOSMavericks() && !base::mac::IsOSYosemite();

+ bool should_clear = !base::mac::IsOS10_9() && !base::mac::IsOS10_10();

if (should_clear) {

// Zero-initialize the IOSurface. Calling IOSurfaceLock/IOSurfaceUnlock

« no previous file with comments | « ui/base/cocoa/base_view.mm ('k') | ui/gfx/mac/scoped_cocoa_disable_screen_updates.h » ('j') | no next file with comments »