third_party/WebKit/Source/core/layout/LayoutThemeMac.mm - Issue 2271653006: base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

Issue 2271653006: base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/mac/mac_util.mm ('K') | « sandbox/mac/pre_exec_delegate.cc ('k') | third_party/WebKit/Source/platform/fonts/mac/FontFamilyMatcherMac.mm » ('j') | third_party/WebKit/Source/platform/mac/VersionUtilMac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

diff --git a/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm b/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

index 318293ed309a4c514000cbbf58edc3feefe257f2..d8d2a531de30c4ad100c22393135aa514da8bfc6 100644

--- a/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

+++ b/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

@@ -256,7 +256,7 @@ bool LayoutThemeMac::needsHackForTextControlWithFontFamily(const AtomicString& f

{

// This hack is only applied on OSX 10.9.

// https://code.google.com/p/chromium/issues/detail?id=515989#c8

- return IsOSMavericks() && family == "BlinkMacSystemFont";

+ return IsOS10_9() && family == "BlinkMacSystemFont";

}

static RGBA32 convertNSColorToColor(NSColor *color)

@@ -478,7 +478,7 @@ bool LayoutThemeMac::isControlStyled(const ComputedStyle& style) const

return true;

// NSPopUpButtonCell on macOS 10.9 doesn't support

// NSUserInterfaceLayoutDirectionRightToLeft.

- if (IsOSMavericks() && style.direction() == RTL)

+ if (IsOS10_9() && style.direction() == RTL)

return true;

}

// Some other cells don't work well when scaled.