chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm - Issue 2271653006: base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

Issue 2271653006: base::mac::IsOSSierra() -> base::mac::IsOS10_12(), etc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/mac/mac_util.mm ('K') | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm ('k') | chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_browsertest.mm » ('j') | third_party/WebKit/Source/platform/mac/VersionUtilMac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

index f5355de05b418819ac3a571b6389b875292bf56c..b20b65a1afb760e439c4a4198fdb60146b71217b 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm

@@ -320,7 +320,7 @@ void OmniboxPopupViewMac::PositionPopup(const CGFloat matrixHeight) {

// the window does not get redrawn. Use a completion handler to make sure

// |popup_| gets redrawn once the animation completes. See

// http://crbug.com/538590 and http://crbug.com/551007 .

- if (base::mac::IsOSElCapitanOrLater()) {

+ if (base::mac::IsAtLeastOS10_11()) {

NSWindow* popup = popup_.get();

[[NSAnimationContext currentContext] setCompletionHandler:^{

[popup display];