Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Issue 2271633002: Update test that rendered incorrectly because orphans and widows are now 2 by default. (Closed)

Created:
4 years, 4 months ago by mstensho (USE GERRIT)
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
chromium-reviews, blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update test that rendered incorrectly because orphans and widows are now 2 by default. The test and the ref were rendered identically (so no failure was reported), but the result was wrong according to the pass condition text. Change the ref to not use multicol, to reduce the risk of something like this going unnoticed in the future. BUG=473509 Committed: https://crrev.com/ed5d4aad98d7eb5203d4c140f348aaf884c62e65 Cr-Commit-Position: refs/heads/master@{#413789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/fast/multicol/span/spanner-first.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/span/spanner-first-expected.html View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 4 months ago (2016-08-23 10:55:58 UTC) #2
eae
LGTM
4 years, 4 months ago (2016-08-23 16:52:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271633002/1
4 years, 4 months ago (2016-08-23 16:52:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 18:18:22 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 18:20:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed5d4aad98d7eb5203d4c140f348aaf884c62e65
Cr-Commit-Position: refs/heads/master@{#413789}

Powered by Google App Engine
This is Rietveld 408576698