Force expandToParagraphBoundary to return a valid EphemeralRange

Force expandToParagraphBoundary to return a valid EphemeralRange

This is a first-aid patch that make expandToParagraphBoundary()
compare the paragraph boundaries found with the input range before
returning, so that the returned range is always a super-range of
the input range, and hence, a valid EphemeralRange.

This patch does not fix the root cause of the bugs, as we:
- do not expect startOfParagraph()'s return value to be beyond that of
endOfParagraph()'s, and
- are planning of getting rid of TextCheckingParagraph, the only client
of expandToParagraphBoundary(), ultimately

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a first-aid patch

Committed: https://crrev.com/8d1974aecc77d407a9ee89d2434f0079b4cc1e40
Cr-Commit-Position: refs/heads/master@{#413942}

[Xiaocheng, 2016-08-23 06:48:06]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 06:48:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-23 07:26:26]

Description was changed from

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

BUG=639521, 639801, 640022, 640030, 640112
==========

to

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a quick-aid patch forcing expandToParagraphBoundary() to
return a valid EphemeralRange by using
VisibleSelection::toNormalizedEphemeralRange instead of constructing
an EphemeralRange directly.

This patch does not fix the root cause of the bugs, as we do not expect
startOfParagraph()'s return value to be beyond that of endOfParagraph()'s.

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a quick-aid patch
==========

[Xiaocheng, 2016-08-23 07:27:28]

Description was changed from

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a quick-aid patch forcing expandToParagraphBoundary() to
return a valid EphemeralRange by using
VisibleSelection::toNormalizedEphemeralRange instead of constructing
an EphemeralRange directly.

This patch does not fix the root cause of the bugs, as we do not expect
startOfParagraph()'s return value to be beyond that of endOfParagraph()'s.

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a quick-aid patch
==========

to

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a first-aid patch forcing expandToParagraphBoundary() to
return a valid EphemeralRange by using
VisibleSelection::toNormalizedEphemeralRange instead of constructing
an EphemeralRange directly.

This patch does not fix the root cause of the bugs, as we do not expect
startOfParagraph()'s return value to be beyond that of endOfParagraph()'s.

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a first-aid patch
==========

[commit-bot: I haz the power, 2016-08-23 08:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 08:09:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-08-23 09:40:28]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 09:41:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 11:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 11:18:27]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-24 01:54:05]

Description was changed from

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a first-aid patch forcing expandToParagraphBoundary() to
return a valid EphemeralRange by using
VisibleSelection::toNormalizedEphemeralRange instead of constructing
an EphemeralRange directly.

This patch does not fix the root cause of the bugs, as we do not expect
startOfParagraph()'s return value to be beyond that of endOfParagraph()'s.

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a first-aid patch
==========

to

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a first-aid patch forcing expandToParagraphBoundary() to
return a valid EphemeralRange by using
VisibleSelection::toNormalizedEphemeralRange instead of constructing
an EphemeralRange directly.

This patch does not fix the root cause of the bugs, as we:
- do not expect startOfParagraph()'s return value to be beyond that of
endOfParagraph()'s, and
- are planning of getting rid of TextCheckingParagraph, the only client
of expandToParagraphBoundary(), ultimately

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a first-aid patch
==========

[Xiaocheng, 2016-08-24 01:54:16]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-24 01:54:16]

PTAL.

[yosin_UTC9, 2016-08-24 02:02:04]

lgtm

Great!

Since most of case we can find sentence boundary correctly. On unusual HTML
cases, we failed
to find sentence boundary. Fixing sentence boundary function isn't simple and
will be change it to use state machine in next quarter. 

This patch is reasonable workaround at this time.

[Xiaocheng, 2016-08-24 02:07:47]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-08-24 02:08:14]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2016-08-24 02:10:11]

Description was changed from

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a first-aid patch forcing expandToParagraphBoundary() to
return a valid EphemeralRange by using
VisibleSelection::toNormalizedEphemeralRange instead of constructing
an EphemeralRange directly.

This patch does not fix the root cause of the bugs, as we:
- do not expect startOfParagraph()'s return value to be beyond that of
endOfParagraph()'s, and
- are planning of getting rid of TextCheckingParagraph, the only client
of expandToParagraphBoundary(), ultimately

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a first-aid patch
==========

to

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a first-aid patch that make expandToParagraphBoundary() 
compare the paragraph boundaries found with the input range before
returning, so that the returned range is always a super-range of
the input range, and hence, a valid EphemeralRange.

This patch does not fix the root cause of the bugs, as we:
- do not expect startOfParagraph()'s return value to be beyond that of
endOfParagraph()'s, and
- are planning of getting rid of TextCheckingParagraph, the only client
of expandToParagraphBoundary(), ultimately

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a first-aid patch
==========

[Xiaocheng, 2016-08-24 02:10:16]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-24 02:10:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 02:16:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 02:18:20]

Description was changed from

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a first-aid patch that make expandToParagraphBoundary() 
compare the paragraph boundaries found with the input range before
returning, so that the returned range is always a super-range of
the input range, and hence, a valid EphemeralRange.

This patch does not fix the root cause of the bugs, as we:
- do not expect startOfParagraph()'s return value to be beyond that of
endOfParagraph()'s, and
- are planning of getting rid of TextCheckingParagraph, the only client
of expandToParagraphBoundary(), ultimately

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a first-aid patch
==========

to

==========
Force expandToParagraphBoundary to return a valid EphemeralRange

This is a first-aid patch that make expandToParagraphBoundary()
compare the paragraph boundaries found with the input range before
returning, so that the returned range is always a super-range of
the input range, and hence, a valid EphemeralRange.

This patch does not fix the root cause of the bugs, as we:
- do not expect startOfParagraph()'s return value to be beyond that of
endOfParagraph()'s, and
- are planning of getting rid of TextCheckingParagraph, the only client
of expandToParagraphBoundary(), ultimately

BUG=639521, 639801, 640022, 640030, 640112
TEST=n/a; this is a first-aid patch

Committed: https://crrev.com/8d1974aecc77d407a9ee89d2434f0079b4cc1e40
Cr-Commit-Position: refs/heads/master@{#413942}
==========

[commit-bot: I haz the power, 2016-08-24 02:18:22]

Patchset 2 (id:??) landed as
https://crrev.com/8d1974aecc77d407a9ee89d2434f0079b4cc1e40
Cr-Commit-Position: refs/heads/master@{#413942}