third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext.html - Issue 2271593002: Convert OffscreenCanvas-getContext tests to testharness.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext.html

Issue 2271593002: Convert OffscreenCanvas-getContext tests to testharness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext-in-worker.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <title>Tests basic functionalities of offscreenCanvas.getContext on the main thr ead.</title>
	fs 2016/08/23 08:50:58 OffscreenCanvas OffscreenCanvas sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 08:50:58, fs wrote: > OffscreenCanvas Done.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

3 <script>	5 <script>

4 description("Tests basic functionalities of offscreenCanvas.getContext on the ma in thread");	6 test(function() {

	7 // Tests constructor of OffscreenCanvas and length/width change
	fs 2016/08/23 08:50:57 Add full stops ('.') at end up sentences - here an Add full stops ('.') at end up sentences - here and all similar cases below. Also, I guess 'length' should really be 'height'. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 08:50:57, fs wrote: > Add full stops ('.') at end up sentences - here and all similar cases below. > > Also, I guess 'length' should really be 'height'. Done.
	8 var aCanvas = new OffscreenCanvas(40, 60);

	9 assert_equals(aCanvas.width, 40);

	10 assert_equals(aCanvas.height, 60);

5	11

6 // Tests onstructor of OffscreenCanvas and length/width change	12 aCanvas.width = 110;

7 var aCanvas = new OffscreenCanvas(40, 60);	13 aCanvas.height = 90;

8 shouldBe("aCanvas.width", "40");	14 assert_equals(aCanvas.width, 110);

9 shouldBe("aCanvas.height", "60");	15 assert_equals(aCanvas.height, 90);

10	16

11 aCanvas.width = 110;	17 aCanvas.width = 0; // Zero dimension is allowed

12 aCanvas.height = 90;	18 assert_equals(aCanvas.width, 0);

13 shouldBe("aCanvas.width", "110");

14 shouldBe("aCanvas.height", "90");

15	19

16 aCanvas.width = 0; // Zero dimension is allowed	20 // Tests object type of getContext('2d')

17 shouldBe("aCanvas.width", "0");	21 var ctx;

	22 ctx = aCanvas.getContext('2d');
	fs 2016/08/23 08:50:57 Maybe merge this with the previous line. Maybe merge this with the previous line. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 08:50:57, fs wrote: > Maybe merge this with the previous line. Done.
	23 assert_true(ctx instanceof OffscreenCanvasRenderingContext2D);
	fs 2016/08/23 08:50:57 Double space after instanceof. Double space after instanceof. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 08:50:57, fs wrote: > Double space after instanceof. Done.
	24 // Calling getContext on a different context type will return null

	25 var ctx2 = aCanvas.getContext("webgl");

	26 assert_equals(ctx2, null);

18	27

19 // Tests object type of getContext('2d')	28 // Calling getContext on the same context type will return the original cont ext type

20 var ctx;	29 var ctx3 = aCanvas.getContext("2d");

21 shouldNotThrow("ctx = aCanvas.getContext('2d')");	30 assert_not_equals(ctx3, null);

22 shouldBeType("ctx", "OffscreenCanvasRenderingContext2D");	31 assert_true(ctx3 == ctx);
	Srirama 2016/08/23 06:34:24 use assert_equals use assert_equals sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 06:34:24, Srirama wrote: > use assert_equals Done.
23	32

24 // Calling getContext on a different context type will return null	33 // TODO: change the below part of the test when webgl is supported.
	Justin Novosad 2016/08/23 15:53:00 This comment is no longer relevant. WebGL works no This comment is no longer relevant. WebGL works now. Please just remove it. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 15:53:00, Justin Novosad wrote: > This comment is no longer relevant. WebGL works now. Please just remove it. Done.
25 var ctx2 = aCanvas.getContext("webgl");	34 // Calling getContext on an unimplemented context type will return null

26 shouldBeNull("ctx2");	35 var bCanvas = new OffscreenCanvas(20, 20);

27	36 var ctx4 = bCanvas.getContext("webgl");

28 // Calling getContext on the same context type will return the original context type	37 assert_true(ctx4 instanceof WebGLRenderingContext);

29 var ctx3 = aCanvas.getContext("2d");	38 });

30 shouldBeNonNull("ctx3");

31 shouldBeTrue("ctx3 == ctx");

32

33 // TODO: change the below part of the test when webgl is supported.

34 // Calling getContext on an unimplemented context type will return null

35 var bCanvas = new OffscreenCanvas(20, 20);

36 var ctx4 = bCanvas.getContext("webgl");

37 shouldBeType("ctx4", "WebGLRenderingContext");

38 </script>	39 </script>

OLD	NEW