third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext-in-worker.html - Issue 2271593002: Convert OffscreenCanvas-getContext tests to testharness.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext-in-worker.html

Issue 2271593002: Convert OffscreenCanvas-getContext tests to testharness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext.html ('K') | « third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext-in-worker-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>Tests that the 2D and webgl context of OffscreenCanvas can be constructed on a worker thread.</title>

3 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/testharness.js"></script>

4 <body>	4 <script src="../../resources/testharnessreport.js"></script>

5 <script id="myWorker" type="text/worker">	5 <script id="myWorker" type="text/worker">

6 self.onmessage = function(e) {	6 self.onmessage = function(e) {
	Srirama 2016/08/23 06:34:24 you can remove 'e'. you can remove 'e'. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 06:34:24, Srirama wrote: > you can remove 'e'. Done.
7 var aCanvas = new OffscreenCanvas(50, 50);	7 var aCanvas = new OffscreenCanvas(50, 50);
	Srirama 2016/08/23 06:34:24 Use same indentation everywhere either 2 or 4. Use same indentation everywhere either 2 or 4. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 06:34:24, Srirama wrote: > Use same indentation everywhere either 2 or 4. Done.
8 var bCanvas = new OffscreenCanvas(50, 50);	8 var bCanvas = new OffscreenCanvas(50, 50);

9 try {	9 try {
	Srirama 2016/08/23 06:34:24 i think you can remove try catch. If there is an e i think you can remove try catch. If there is an exception test will fail anyway. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 06:34:24, Srirama wrote: > i think you can remove try catch. If there is an exception test will fail > anyway. Done.
10 var ctx1 = aCanvas.getContext('2d');	10 var ctx1 = aCanvas.getContext('2d');

11 var ctx2 = bCanvas.getContext('webgl');	11 var ctx2 = bCanvas.getContext('webgl');

12 if (!(ctx1 instanceof OffscreenCanvasRenderingContext2D)) {	12 if (!(ctx1 instanceof OffscreenCanvasRenderingContext2D)) {
	Srirama 2016/08/23 06:34:24 can we assert these instead of conditions ? assert can we assert these instead of conditions ? assert_true(ctx1 instanceof OffscreenCanvasRenderingContext2D); assert_true(ctx2 instanceof WebGLRenderingContext); self.postMessage("success"); fs 2016/08/23 08:50:57 It needs some additional setup [1], but is probabl Show quoted text On 2016/08/23 at 06:34:24, Srirama wrote: > can we assert these instead of conditions ? > assert_true(ctx1 instanceof OffscreenCanvasRenderingContext2D); > assert_true(ctx2 instanceof WebGLRenderingContext); > self.postMessage("success"); It needs some additional setup [1], but is probably a good idea in this case. [1] https://github.com/w3c/testharness.js/blob/8550cfecab28e680545486a85887334a37... sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 06:34:24, Srirama wrote: > can we assert these instead of conditions ? > assert_true(ctx1 instanceof OffscreenCanvasRenderingContext2D); > assert_true(ctx2 instanceof WebGLRenderingContext); > self.postMessage("success"); Done. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 08:50:57, fs wrote: > On 2016/08/23 at 06:34:24, Srirama wrote: > > can we assert these instead of conditions ? > > assert_true(ctx1 instanceof OffscreenCanvasRenderingContext2D); > > assert_true(ctx2 instanceof WebGLRenderingContext); > > self.postMessage("success"); > > It needs some additional setup [1], but is probably a good idea in this case. > > [1] > https://github.com/w3c/testharness.js/blob/8550cfecab28e680545486a85887334a37... Done.
13 self.postMessage("aCanvas.getContext('2d') returns " + ctx1);	13 self.postMessage("aCanvas.getContext('2d') returns " + ctx1);

14 } else if (!(ctx2 instanceof WebGLRenderingContext)) {	14 } else if (!(ctx2 instanceof WebGLRenderingContext)) {

15 self.postMessage("bCanvas.getContext('webgl') returns " + ctx2);	15 self.postMessage("bCanvas.getContext('webgl') returns " + ctx2);

16 } else {	16 } else {

17 self.postMessage("success");	17 self.postMessage("success");

18 }	18 }

19 } catch (e) {	19 } catch (e) {

20 self.postMessage(e);	20 self.postMessage(e);

21 }	21 }

22 };	22 };

23 </script>	23 </script>

	24 <script>

	25 async_test(function(t) {

	26 function makeWorker(script) {

	27 var blob = new Blob([script]);

	28 return new Worker(URL.createObjectURL(blob));

	29 }

24	30

25 <script>	31 function handleMessageFromWorker(msg) {

26 jsTestIsAsync = true;	32 assert_equals(msg.data, "success");

27 description("Tests that the 2D and webgl context of OffscreenCanvas can be const ructed on a worker thread.");	33 t.done();

	34 }

28	35

29 function makeWorker(script) {	36 var worker = makeWorker(document.getElementById('myWorker').textContent);

30 var blob = new Blob([script]);	37 worker.addEventListener('message', handleMessageFromWorker);
	Srirama 2016/08/23 06:34:24 may be inline hte function here. like worker.onme may be inline hte function here. like worker.onmessage = t.step-func_done(function() { assert_equals(msg.data, "success"); }); sivag 2016/08/25 07:39:01 Done. Modified using fetch_tests_from_worker. Show quoted text On 2016/08/23 06:34:24, Srirama wrote: > may be inline hte function here. like > worker.onmessage = t.step-func_done(function() { > assert_equals(msg.data, "success"); > }); Done. Modified using fetch_tests_from_worker. sivag 2016/08/25 07:39:01 Done. Show quoted text On 2016/08/23 06:34:24, Srirama wrote: > may be inline hte function here. like > worker.onmessage = t.step-func_done(function() { > assert_equals(msg.data, "success"); > }); Done.
31 return new Worker(URL.createObjectURL(blob));	38 worker.postMessage("");

32 }	39 });

33

34 function handleMessageFromWorker(msg)

35 {

36 if (msg.data == "success") {

37 testPassed("getContext('2d') and getContext('webgl') works on a worker t hread");

38 } else {

39 testFailed(msg.data);

40 }

41 finishJSTest();

42 }

43

44 var worker = makeWorker(document.getElementById('myWorker').textContent);

45 worker.addEventListener('message', handleMessageFromWorker);

46 worker.postMessage("");

47 </script>	40 </script>

48

49 </body>

50 </html>

OLD	NEW