Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2271583005: Stop parsing disable_outdated_build_detector.exe.pdb as a PE file (Closed)

Created:
4 years, 4 months ago by brucedawson
Modified:
4 years, 4 months ago
Reviewers:
S. Ganesh
CC:
chromium-reviews, grt (UTC plus 2), Dirk Pranke, Reid Kleckner
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop parsing disable_outdated_build_detector.exe.pdb as a PE file disable_outdated_build_detector.exe.pdb was incorrectly tagged with: 'filegroup': ['symsrc'], This tells the symbol processing script to treat it as a PE file (portable executable file, a .dll or .exe) which then fails because it is actually a .pdb file. BUG=639476 Committed: https://crrev.com/605009fb1ec3b30b1d82a67838e9795b20ada89b Cr-Commit-Position: refs/heads/master@{#414123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
brucedawson
This fixes a symbol error introduced by: https://codereview.chromium.org/2255783003/ I've never touched this .cfg file before, ...
4 years, 4 months ago (2016-08-24 18:08:56 UTC) #4
S. Ganesh
lgtm
4 years, 4 months ago (2016-08-24 18:19:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271583005/1
4 years, 4 months ago (2016-08-24 19:42:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 19:46:37 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/605009fb1ec3b30b1d82a67838e9795b20ada89b Cr-Commit-Position: refs/heads/master@{#414123}
4 years, 4 months ago (2016-08-24 19:48:58 UTC) #12
grt (UTC plus 2)
4 years, 4 months ago (2016-08-24 19:59:31 UTC) #13
Message was sent while issue was closed.
Thanks for fixing this!

Powered by Google App Engine
This is Rietveld 408576698