Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/dom/scripts/dartmetadata.py

Issue 227153010: Change HtmlCollection to appear as List<Node> and getElementsByX return ListNode|HtmlCollection (de… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/dartmetadata.py
diff --git a/tools/dom/scripts/dartmetadata.py b/tools/dom/scripts/dartmetadata.py
index fee093ecdce7fecc715689b1f837dd5cad518d4e..a86424fa098766f35e89b3fd2a76976354873a26 100644
--- a/tools/dom/scripts/dartmetadata.py
+++ b/tools/dom/scripts/dartmetadata.py
@@ -68,6 +68,16 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Returns('Window|=Object|Null')",
],
+ 'Document.getElementsByTagName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
+ 'Document.getElementsByClassName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
# Methods returning Window can return a local window, or a cross-frame
# window (=Object) that needs wrapping.
'Window': [
@@ -88,6 +98,16 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Returns('JSExtendableArray')",
],
+ 'Element.getElementsByTagName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
+ 'Element.getElementsByClassName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
"ErrorEvent.error": [
"@Creates('Null')", # Only returns values created elsewhere.
],
@@ -255,6 +275,16 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@annotation_Returns_SerializedScriptValue",
],
+ 'ShadowRoot.getElementsByTagName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
+ 'ShadowRoot.getElementsByClassName': [
+ "@Creates('NodeList|HtmlCollection')",
+ "@Returns('NodeList|HtmlCollection')",
+ ],
+
'SQLResultSetRowList.item': ["@Creates('=Object')"],
# Touch targets are Elements in a Document, or the Document.

Powered by Google App Engine
This is Rietveld 408576698