Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 227153008: define LIBC_GLIBC as 1 for consistency (Closed)

Created:
6 years, 8 months ago by Mostyn Bramley-Moore
Modified:
6 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

define LIBC_GLIBC as 1 for consistency Most of the other defines in build/build_config.h are set to 1, let's define LIBC_GLIBC as 1 for consistency. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/build_config.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mostyn Bramley-Moore
@Paweł: PTAL at this trivial patch.
6 years, 8 months ago (2014-04-07 17:08:50 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 8 months ago (2014-04-07 17:54:59 UTC) #2
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 8 months ago (2014-04-07 19:57:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/227153008/1
6 years, 8 months ago (2014-04-07 19:58:21 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 23:51:48 UTC) #5
Message was sent while issue was closed.
Change committed as 262255

Powered by Google App Engine
This is Rietveld 408576698