Remove dependency on Profile's IsOffTheRecord in favicon_handler.

chrome/browser/favicon/favicon_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_
 #define CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "chrome/browser/favicon/favicon_service.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/common/ref_counted_util.h"
 #include "content/public/common/favicon_url.h"
 #include "ui/gfx/favicon_size.h"
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
+class FaviconDriver;
 class FaviconHandlerDelegate;
 class Profile;
 class SkBitmap;
 
 namespace base {
 class RefCountedMemory;
 }
 
 namespace content {
 class NavigationEntry;
@@ skipping 45 matching lines @@
 // NavigationEntry and notifies the database to save the favicon.
 
 class FaviconHandler {
  public:
   enum Type {
     FAVICON,
     TOUCH,
   };
 
   FaviconHandler(Profile* profile,
+                 FaviconDriver* driver,
                  FaviconHandlerDelegate* delegate,
                  Type icon_type);
   virtual ~FaviconHandler();
 
   // Initiates loading the favicon for the specified url.
   void FetchFavicon(const GURL& url);
 
   // Message Handler.  Must be public, because also called from
   // PrerenderContents. Collects the |image_urls| list.
   void OnUpdateFaviconURL(int32 page_id,
@@ skipping 182 matching lines @@
 
   // The prioritized favicon candidates from the page back from the renderer.
   std::deque<content::FaviconURL> image_urls_;
 
   // The FaviconBitmapResults from history.
   std::vector<chrome::FaviconBitmapResult> history_results_;
 
   // The Profile associated with this handler.
   Profile* profile_;
 
+  // The driver which implements platform-specific Favicon operations.
+  FaviconDriver* driver_;  // weak

[stevenjb, 2014/04/08 15:55:57]

I haven't seen "Driver" used much in Chrome code, and the meaning was not
immediately clear to me. Maybe use "PlatformDelegate" instead? Or would it be
possible just to integrate this with |delegate_|? That seems like it would be
simpler since FaviconHandlerDelegate already has a dependency on src/content for
GetActiveEntry.

[blundell, 2014/04/08 16:01:57]

FooDriver is the naming convention for the interface that abstracts the
dependencies that the core code of a layered component Foo has on the content
API.

In the medium term the FaviconHandlerDelegate will be integrated into the
FaviconDriver interface and content-based impl, yes.

On 2014/04/08 15:55:57, stevenjb wrote:

+
   // This handler's delegate.
   FaviconHandlerDelegate* delegate_;  // weak
 
   // Best image we've seen so far.  As images are downloaded from the page they
   // are stored here. When there is an exact match, or no more images are
   // available the favicon service and the NavigationEntry are updated (assuming
   // the image is for a favicon).
   FaviconCandidate best_favicon_candidate_;
 
   DISALLOW_COPY_AND_ASSIGN(FaviconHandler);
 };
 
 #endif  // CHROME_BROWSER_FAVICON_FAVICON_HANDLER_H_