Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: chrome/browser/favicon/DEPS

Issue 227153007: Remove dependency on Profile's IsOffTheRecord in favicon_handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FAVICON_create_core_dir
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Favicon is being made into a Browser Component, so we have these 2 # Favicon is being made into a Browser Component, so we have these
3 # three basic rules followed by temporary exceptions. Please don't 3 # three basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/chrome_notification_types.h", 6 "+chrome/browser/chrome_notification_types.h",
7 "+chrome/browser/common", 7 "+chrome/browser/common",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 9
10 # Permanently-allowed DEPS beyond the standard Browser 10 # Permanently-allowed DEPS beyond the standard Browser
11 # Components-like DEPS above go here. 11 # Components-like DEPS above go here.
12 "+chrome/browser/search/search.h", 12 "+chrome/browser/search/search.h",
13 "+components/favicon/content",
13 "+components/favicon/core", 14 "+components/favicon/core",
14 "+third_party/skia/include/core/SkBitmap.h", 15 "+third_party/skia/include/core/SkBitmap.h",
15 16
16 # TODO(caitkp): Bring this list to zero. 17 # TODO(caitkp): Bring this list to zero.
17 # 18 #
18 # Do not add to the list of temporarily-allowed dependencies below, 19 # Do not add to the list of temporarily-allowed dependencies below,
19 # and please do not introduce more #includes of these files. 20 # and please do not introduce more #includes of these files.
20 "!chrome/browser/bookmarks/bookmark_service.h", 21 "!chrome/browser/bookmarks/bookmark_service.h",
21 "!chrome/browser/history/history_backend.h", 22 "!chrome/browser/history/history_backend.h",
22 "!chrome/browser/history/history_details.h", 23 "!chrome/browser/history/history_details.h",
(...skipping 11 matching lines...) Expand all
34 'favicon_util\.(h|cc)': [ 35 'favicon_util\.(h|cc)': [
35 "-chrome", 36 "-chrome",
36 "-chrome/browser", 37 "-chrome/browser",
37 "+chrome/browser/favicon/favicon_util.h", 38 "+chrome/browser/favicon/favicon_util.h",
38 "+chrome/common/favicon/favicon_types.h", 39 "+chrome/common/favicon/favicon_types.h",
39 "+chrome/common/icon_messages.h", 40 "+chrome/common/icon_messages.h",
40 "!chrome/browser/history/history_types.h", 41 "!chrome/browser/history/history_types.h",
41 "!chrome/browser/history/select_favicon_frames.h", 42 "!chrome/browser/history/select_favicon_frames.h",
42 ] 43 ]
43 } 44 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.h » ('j') | chrome/browser/favicon/favicon_handler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698