Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 227153007: Remove dependency on Profile's IsOffTheRecord in favicon_handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FAVICON_create_core_dir
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 int32 page_id, 63 int32 page_id,
64 const std::vector<content::FaviconURL>& candidates) OVERRIDE; 64 const std::vector<content::FaviconURL>& candidates) OVERRIDE;
65 65
66 // Saves the favicon for the current page. 66 // Saves the favicon for the current page.
67 void SaveFavicon(); 67 void SaveFavicon();
68 68
69 // FaviconHandlerDelegate methods. 69 // FaviconHandlerDelegate methods.
70 virtual content::NavigationEntry* GetActiveEntry() OVERRIDE; 70 virtual content::NavigationEntry* GetActiveEntry() OVERRIDE;
71 virtual int StartDownload(const GURL& url, int max_bitmap_size) OVERRIDE; 71 virtual int StartDownload(const GURL& url, int max_bitmap_size) OVERRIDE;
72 virtual void NotifyFaviconUpdated(bool icon_url_changed) OVERRIDE; 72 virtual void NotifyFaviconUpdated(bool icon_url_changed) OVERRIDE;
73 virtual bool IsOffTheRecord() OVERRIDE;
73 74
74 // Favicon download callback. 75 // Favicon download callback.
75 void DidDownloadFavicon( 76 void DidDownloadFavicon(
76 int id, 77 int id,
77 int http_status_code, 78 int http_status_code,
78 const GURL& image_url, 79 const GURL& image_url,
79 const std::vector<SkBitmap>& bitmaps, 80 const std::vector<SkBitmap>& bitmaps,
80 const std::vector<gfx::Size>& original_bitmap_sizes); 81 const std::vector<gfx::Size>& original_bitmap_sizes);
81 82
82 private: 83 private:
(...skipping 15 matching lines...) Expand all
98 scoped_ptr<FaviconHandler> favicon_handler_; 99 scoped_ptr<FaviconHandler> favicon_handler_;
99 100
100 // Handles downloading touchicons. It is NULL if 101 // Handles downloading touchicons. It is NULL if
101 // browser_defaults::kEnableTouchIcon is false. 102 // browser_defaults::kEnableTouchIcon is false.
102 scoped_ptr<FaviconHandler> touch_icon_handler_; 103 scoped_ptr<FaviconHandler> touch_icon_handler_;
103 104
104 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper); 105 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper);
105 }; 106 };
106 107
107 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 108 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698