|
|
Created:
6 years, 8 months ago by tfarina Modified:
6 years, 8 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdds the foundation for extensions test suite.
We need to build our custom test suite and run it because we will need
to setup some extensions pieces in order to make the existing tests
pass.
Mainly, the next work will be to setup an ExtensionsClient and call it
from our TestSuite.
This just adds the foundation from which we will iterate and fix the
current failing unit tests. It does not do anything else different from
the current behavior.
BUG=348066
TEST=extensions_unittests still runs
R=yoz@chromium.org,jamescook@chromium.org
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262655
Patch Set 1 #
Total comments: 1
Messages
Total messages: 32 (0 generated)
PTAL. Thanks,
This looks fine to me, but I'll defer to yoz@ who has been looking at tests recently.
LGTM https://chromiumcodereview.appspot.com/227153004/diff/1/extensions/test/exten... File extensions/test/extensions_unittests_main.cc (right): https://chromiumcodereview.appspot.com/227153004/diff/1/extensions/test/exten... extensions/test/extensions_unittests_main.cc:28: void ExtensionsTestSuite::Initialize() { It doesn't seem like these are doing anything for us, so there's no need to override them.
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/227153004/1
Message was sent while issue was closed.
Change committed as 262655 |