Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2271513002: MD Downloads: fix 'More actions...' menu in RTL (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: fix 'More actions...' menu in RTL Polymer's iron-fit-behavior flips these values for us since this PR: https://github.com/PolymerElements/iron-fit-behavior/pull/38/ And because we're using dir="$i18n{textdirection}", it's guaranteed to be correct at any time in the page's life cycle. R=tsergeant@chromium.org BUG=640058 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fea3a25f631f9e86c37c4d0d7823733cb5b2fb3f Cr-Commit-Position: refs/heads/master@{#413656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Dan Beam
4 years, 4 months ago (2016-08-23 01:18:00 UTC) #2
tsergeant
lgtm
4 years, 4 months ago (2016-08-23 01:45:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271513002/1
4 years, 4 months ago (2016-08-23 02:25:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 03:34:43 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 03:38:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fea3a25f631f9e86c37c4d0d7823733cb5b2fb3f
Cr-Commit-Position: refs/heads/master@{#413656}

Powered by Google App Engine
This is Rietveld 408576698