Suppressing screenshot messages as long as the login screen is shown and no user is logged in.

Suppressing screenshot messages as long as the login screen is shown and no user is logged in.

BUG=235217
TEST=visual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216866

[Mr4D (OOO till 08-26), 2013-08-09 19:38:25]

Please have a look!

[James Cook, 2013-08-09 20:09:16]

LGTM with nits

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
File chrome/browser/ui/ash/screenshot_taker.cc (right):

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
chrome/browser/ui/ash/screenshot_taker.cc:357: // while no user the login
screen.
nit: Maybe add the "why" here -- because it's confusing when the user logs in
and there are notifications for screen shots.

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
File chrome/browser/ui/ash/screenshot_taker_unittest.cc (right):

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
chrome/browser/ui/ash/screenshot_taker_unittest.cc:102: // Note that within the
testframework the LoginState object will always claim
testframework -> test framework

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
chrome/browser/ui/ash/screenshot_taker_unittest.cc:134: 
nit: maybe no blank line here?

[Mr4D (OOO till 08-26), 2013-08-09 20:35:45]

Addressed! Thanks!

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
File chrome/browser/ui/ash/screenshot_taker.cc (right):

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
chrome/browser/ui/ash/screenshot_taker.cc:357: // while no user the login
screen.
On 2013/08/09 20:09:16, James Cook wrote:
> nit: Maybe add the "why" here -- because it's confusing when the user logs in
> and there are notifications for screen shots.

Done.

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
File chrome/browser/ui/ash/screenshot_taker_unittest.cc (right):

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
chrome/browser/ui/ash/screenshot_taker_unittest.cc:102: // Note that within the
testframework the LoginState object will always claim
On 2013/08/09 20:09:16, James Cook wrote:
> testframework -> test framework

Done.

https://codereview.chromium.org/22715006/diff/3001/chrome/browser/ui/ash/scre...
chrome/browser/ui/ash/screenshot_taker_unittest.cc:134: 
On 2013/08/09 20:09:16, James Cook wrote:
> nit: maybe no blank line here?

Done.

[commit-bot: I haz the power, 2013-08-09 20:37:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/22715006/24001

[commit-bot: I haz the power, 2013-08-09 23:57:32]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-08-10 00:29:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/22715006/24001

[commit-bot: I haz the power, 2013-08-10 15:19:54]

Change committed as 216866