Skip non-AA intersect rects in GrReducedClip

Skip non-AA intersect rects in GrReducedClip

Skips non-AA rects whose op is intersect or replace, and who do not
precede elements that grow the clip, by tightening fIBounds.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271493002

Committed: https://skia.googlesource.com/skia/+/5ecbbbef58a5720a376191b75956abfb5098fc0d

[csmartdalton, 2016-08-23 00:26:26]

Description was changed from

==========
Skip non-AA intersect rects in GrReducedClip

Skips non-AA rects whose op is intersect or replace, and who do not
precede elements that grow the clip, by tightening fIBounds.

BUG=skia:
==========

to

==========
Skip non-AA intersect rects in GrReducedClip

Skips non-AA rects whose op is intersect or replace, and who do not
precede elements that grow the clip, by tightening fIBounds.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271493002
==========

[csmartdalton, 2016-08-23 00:32:38]

csmartdalton@google.com changed reviewers:
+ bsalomon@google.com

[csmartdalton, 2016-08-23 00:32:38]

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp
File src/gpu/GrReducedClip.cpp (right):

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp#n...
src/gpu/GrReducedClip.cpp:165: }
I decided it wasn't worth it to call SkPath.isRect().

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp#n...
src/gpu/GrReducedClip.cpp:173: Element::kRect_Type == element->getType()) {
I suppose we could do:

isAA() || IsPixelAligned()

But I un-scientifically decided it wasn't worth it.

[bsalomon, 2016-08-23 13:21:00]

lgtm

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp
File src/gpu/GrReducedClip.cpp (right):

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp#n...
src/gpu/GrReducedClip.cpp:165: }
On 2016/08/23 00:32:38, csmartdalton wrote:
> I decided it wasn't worth it to call SkPath.isRect().

Rect/RRect paths should already be detected by now.

[csmartdalton, 2016-08-23 20:04:18]

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp
File src/gpu/GrReducedClip.cpp (right):

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp#n...
src/gpu/GrReducedClip.cpp:165: }
On 2016/08/23 13:20:59, bsalomon wrote:
> On 2016/08/23 00:32:38, csmartdalton wrote:
> > I decided it wasn't worth it to call SkPath.isRect().
> 
> Rect/RRect paths should already be detected by now.

You mean something upstack un-inverts the path and flips the op?

[csmartdalton, 2016-08-23 20:04:24]

The CQ bit was checked by csmartdalton@google.com

[csmartdalton, 2016-08-23 20:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2271493002/#ps20001
(title: "rebase, remove dependency")

[commit-bot: I haz the power, 2016-08-23 20:04:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsalomon, 2016-08-23 20:19:12]

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp
File src/gpu/GrReducedClip.cpp (right):

https://codereview.chromium.org/2271493002/diff/1/src/gpu/GrReducedClip.cpp#n...
src/gpu/GrReducedClip.cpp:165: }
On 2016/08/23 20:04:17, csmartdalton wrote:
> On 2016/08/23 13:20:59, bsalomon wrote:
> > On 2016/08/23 00:32:38, csmartdalton wrote:
> > > I decided it wasn't worth it to call SkPath.isRect().
> > 
> > Rect/RRect paths should already be detected by now.
> 
> You mean something upstack un-inverts the path and flips the op?

Oh right, inverse fill. No, not now. Though, I plan to replace
SkClipStack::Element with GrShape in the clip stack, which does understand
inverse rects.

[commit-bot: I haz the power, 2016-08-23 20:26:42]

Description was changed from

==========
Skip non-AA intersect rects in GrReducedClip

Skips non-AA rects whose op is intersect or replace, and who do not
precede elements that grow the clip, by tightening fIBounds.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271493002
==========

to

==========
Skip non-AA intersect rects in GrReducedClip

Skips non-AA rects whose op is intersect or replace, and who do not
precede elements that grow the clip, by tightening fIBounds.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2271493002

Committed:
https://skia.googlesource.com/skia/+/5ecbbbef58a5720a376191b75956abfb5098fc0d
==========

[commit-bot: I haz the power, 2016-08-23 20:26:43]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5ecbbbef58a5720a376191b75956abfb5098fc0d