Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2271483002: Milo: Add a login url (Closed)

Created:
4 years, 4 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Add a login url So that users can authenticate themselves. BUG=637375 Committed: https://github.com/luci/luci-go/commit/e8799958f18e1d896eb636c1cf2dd8b152f49a15

Patch Set 1 #

Patch Set 2 : Retrain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -1 line) Patch
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_no_builds.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_with_builds.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-frontend.testableFrontpage-Basic_frontpage.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-settings.TestableSettings-Settings.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-canceled.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-exception.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-hang.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-link.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-patch-failure.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-pending.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-timeout.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-unicode.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-swarming.TestableLog-Basic_log.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
M milo/appengine/frontend/static/buildbot/css/default.css View 1 chunk +7 lines, -0 lines 0 comments Download
M milo/appengine/frontend/templates/buildbot/includes/buildbot.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
M milo/appengine/settings/themes.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Ryan Tseng
ptal
4 years, 3 months ago (2016-08-30 20:37:53 UTC) #10
Vadim Sh.
lgtm
4 years, 3 months ago (2016-08-30 21:24:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271483002/20001
4 years, 3 months ago (2016-08-30 21:38:21 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:46:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/e8799958f18e1d896eb636c1cf2dd8b152f49a15

Powered by Google App Engine
This is Rietveld 408576698