Change rebaseline-cl command to trigger any necessary try jobs.

Change rebaseline-cl command to trigger any necessary try jobs.

BUG=639533
Committed: https://crrev.com/acfc1b0b164003d71a717198cec888a52fc1f1c8
Cr-Commit-Position: refs/heads/master@{#413770}

[qyearsley, 2016-08-23 04:51:38]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[qyearsley, 2016-08-23 04:51:50]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, wkorman@chromium.org

[commit-bot: I haz the power, 2016-08-23 04:52:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2016-08-23 05:23:59]

lgtm

https://codereview.chromium.org/2271463002/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
(right):

https://codereview.chromium.org/2271463002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:33:
"for different platforms should be optimized (consolidated).")
'will' vs 'should', I think, right? They definitely will be, as part of the
script?

https://codereview.chromium.org/2271463002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:99:
_log.info('Triggering try jobs for: %s', ',
'.join(sorted(builders_without_builds)))
I feel like there will be situations where people may need/want to rerun all try
jobs rebaseline-cl needs, and having a flag they can pass to easily force a
re-run could be useful, but we can wait to make sure that actually happens.

For example, what if one trybot is in a bad state and incorrectly reports a
bunch of random LayoutTest failures. Eng knows those don't really need to be
rebaselined. But I suppose one can just not add those fetched baselines to CL.

So, yeah, I don't have a specific failure situation in mind yet, but wanted to
share the thought in any case.

[commit-bot: I haz the power, 2016-08-23 06:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 06:18:26]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-08-23 15:31:00]

lgtm w/ wkorman's help nit addressed.

[qyearsley, 2016-08-23 15:53:52]

https://codereview.chromium.org/2271463002/diff/40001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
(right):

https://codereview.chromium.org/2271463002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:33:
"for different platforms should be optimized (consolidated).")
On 2016/08/23 at 05:23:59, wkorman wrote:
> 'will' vs 'should', I think, right? They definitely will be, as part of the
script?

Right; done.

https://codereview.chromium.org/2271463002/diff/40001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py:99:
_log.info('Triggering try jobs for: %s', ',
'.join(sorted(builders_without_builds)))
On 2016/08/23 at 05:23:59, wkorman wrote:
> I feel like there will be situations where people may need/want to rerun all
try jobs rebaseline-cl needs, and having a flag they can pass to easily force a
re-run could be useful, but we can wait to make sure that actually happens.
> 
> For example, what if one trybot is in a bad state and incorrectly reports a
bunch of random LayoutTest failures. Eng knows those don't really need to be
rebaselined. But I suppose one can just not add those fetched baselines to CL.
> 
> So, yeah, I don't have a specific failure situation in mind yet, but wanted to
share the thought in any case.

Right now, if one wants to re-trigger a try job on a particular bot, the easiest
way is probably `git cl try -b <builder-name>`; once that job's finished,
rebaseline-cl would only used results from the latest run.


Side note: in the original discussion of rebaselining from try jobs, I was
thinking that the whole rebaseline process (including triggering the try jobs,
rebaselining, and running `webkit-patch rebaseline-cl`) could be done in a try
job (probably on linux VMs). But I think this would be something to explore
later.

[qyearsley, 2016-08-23 15:53:55]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-08-23 15:53:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2271463002/#ps60001
(title: "should -> will")

[commit-bot: I haz the power, 2016-08-23 15:54:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 17:24:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-23 17:26:24]

Description was changed from

==========
Change rebaseline-cl command to trigger any necessary try jobs.

BUG=639533
==========

to

==========
Change rebaseline-cl command to trigger any necessary try jobs.

BUG=639533

Committed: https://crrev.com/acfc1b0b164003d71a717198cec888a52fc1f1c8
Cr-Commit-Position: refs/heads/master@{#413770}
==========

[commit-bot: I haz the power, 2016-08-23 17:26:25]

Patchset 4 (id:??) landed as
https://crrev.com/acfc1b0b164003d71a717198cec888a52fc1f1c8
Cr-Commit-Position: refs/heads/master@{#413770}