Chromium Code Reviews
DescriptionRevert of Enable whitelist generation for official builds. (patchset #2 id:20001 of https://codereview.chromium.org/2241383004/ )
Reason for revert:
This CL breaks android perf trybots.
Original issue's description:
> Reland of Enable whitelist generation for official builds.
>
> Previous: https://codereview.chromium.org/2175413004/
>
> Currently, all resources are included in PAK files when Chrome is
> built locally. Only official_buildbot.sh uses a resource whitelist. This CL
> enables local builds to use resource whitelisting by setting the
> enable_resource_whitelist_generation gn flag to true, or by building an
> official build.
>
> This will allow developers to more easily monitor the changes in APK size
> for each commit they make.
>
> However, a large amount of output is generated (_pragma is used to
> create warnings to allow whitelisted resources to be listed), so for now
> the whitelist will only be generated for official builds.
>
> This change results in a ~1.5 mb difference when calculating the APK size with resource_sizes.py.
>
> BUG=632385
>
> Committed: https://crrev.com/e19e7089b508c4c6d6d9ea022068e2ee93a68490
> Cr-Commit-Position: refs/heads/master@{#413584}
TBR=agrieve@chromium.org,dpranke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632385
Review-Url: https://codereview.chromium.org/2266363002
Cr-Commit-Position: refs/heads/master@{#413642}
(cherry picked from commit 84ccaf08da81aa46ea6199cffe9a8443b009cf97)
Committed: https://chromium.googlesource.com/chromium/src/+/ad25208d651e8b7438a019629204bd1a8490aa09
Patch Set 1 #
Messages
Total messages: 3 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||