Milo: Internal buildbot masters support

milo/appengine/buildbot/build_test.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "encoding/json"
         "flag"
         "fmt"
         "io/ioutil"
         "path"
         "strings"
         "testing"
 
         "github.com/luci/gae/impl/memory"
+        "github.com/luci/gae/service/datastore"
         "github.com/luci/luci-go/common/clock/testclock"
+        "github.com/luci/luci-go/milo/common/miloerror"
         . "github.com/smartystreets/goconvey/convey"
         "golang.org/x/net/context"
 )
 
 var generate = flag.Bool("test.generate", false, "Generate expectations instead of running tests.")
 
 func load(name string) ([]byte, error) {
         filename := strings.Join([]string{"expectations", name}, "/")
         return ioutil.ReadFile(filename)
 }
@@ skipping 36 matching lines @@
         Convey(`A test Environment`, t, func() {
 
                 for _, tc := range testCases {
                         Convey(fmt.Sprintf("Test Case: %s/%s", tc.builder, tc.build), func() {
                                 build, err := build(c, "debug", tc.builder, tc.build)
                                 So(err, ShouldBeNil)
                                 fname := fmt.Sprintf("%s.%s.build.json", tc.builder, tc.build)
                                 So(build, shouldMatchExpectationsFor, fname)
                         })
                 }
+
+                Convey(`Disallow anonomyous users from accessing internal builds`, func() {
+                        ds := datastore.Get(c)
+                        ds.Put(&buildbotBuild{
+                                Master:      "fake",
+                                Buildername: "fake",
+                                Number:      1,
+                                Internal:    true,
+                        })
+                        b, err := getBuild(c, "fake", "fake", "1")
+                        So(b, ShouldBeNil)
+                        So(err, ShouldResemble, miloerror.Error{
+                                Message: "Cannot fetch project buildbot-internal:\ndatastore: no such entity",
+                                Code:    500,
+                        })
+                })
         })
 }