Milo: Internal buildbot masters support

milo/appengine/buildbot/master.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "bytes"
         "compress/gzip"
         "encoding/json"
@@ skipping 42 matching lines @@
         return
 }
 
 // GetAllBuilders returns a resp.Module object containing all known masters
 // and builders.
 func GetAllBuilders(c context.Context) (*resp.Module, error) {
         result := &resp.Module{Name: "Buildbot"}
         // Fetch all Master entries from datastore
         ds := datastore.Get(c)
         q := datastore.NewQuery("buildbotMasterEntry")
-        // TODO(hinoka): Support internal queries.
-        q = q.Eq("Internal", false)
         // TODO(hinoka): Maybe don't look past like a month or so?
         entries := []*buildbotMasterEntry{}
         err := ds.GetAll(q, &entries)
         if err != nil {
                 return nil, err
         }
 
         // Add each builder from each master entry into the result.
         // TODO(hinoka): FanInOut this?
         for _, entry := range entries {
+                if entry.Internal {
+                        // Bypass the master if it's an internal master and the user is not
+                        // part of the buildbot-private project.
+                        if !settings.IsAllowed(c, "buildbot-private") {

[Vadim Sh., 2016/08/23 18:53:06]

errors like this is why its better to deduplicate magic strings :) In other
places it is "buildbot-internal".

Also IsAllowed returns tuple (bool, error). This would not compile :-/

[Ryan Tseng, 2016/08/23 22:00:15]

doh

+                                continue
+                        }
+                }
                 master := &buildbotMaster{}
                 err = decodeMasterEntry(c, entry, master)
                 if err != nil {
                         log.WithError(err).Errorf(c, "Could not decode %s", entry.Name)
                         continue
                 }
                 ml := resp.MasterListing{Name: entry.Name}
-                // TODO(hinoka): Sort
                 // Sort the builder listing.
                 sb := make([]string, 0, len(master.Builders))
                 for bn := range master.Builders {
                         sb = append(sb, bn)
                 }
                 sort.Strings(sb)
                 for _, bn := range sb {
                         ml.Builders = append(ml.Builders, resp.Link{
                                 Label: bn,
                                 // Go templates escapes this for us, and also
                                 // slashes are not allowed in builder names.
                                 URL: fmt.Sprintf("/buildbot/%s/%s", entry.Name, bn),
                         })
                 }
                 result.Masters = append(result.Masters, ml)
         }
         return result, nil
 }